Honeypot time limit applied is always at least double configured value plus one.
$honeypot_time_limit = $honeypot_time_limit + (int) min($honeypot_time_limit + exp($number), 2592000);
should be
$honeypot_time_limit = (int) min($honeypot_time_limit + exp($number), 2592000) - 1;
perhaps.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2277089-fix-for-time-limit-doubling.patch | 1.35 KB | drupoz |
Comments
Comment #1
drupoz commentedor
$honeypot_time_limit = (int) min($honeypot_time_limit + exp($number) - 1, 2592000);rather.
Comment #2
drupoz commentedComment #3
drupoz commentedComment #4
geerlingguy commentedThis bug exists in 7.x as well? I thought I had it fixed... but I'll do more testing, and also make sure we add an automated test for this—don't want to reintroduce the bug again at a later time...
Comment #5
geerlingguy commentedComment #9
geerlingguy commentedOkay, I fixed 7.x-1.x and 6.x-1.x. Moving to 8.x, where I'm going to add tests, then backport the tests to 7.x. Someday I'll be back down to two major versions :P
Comment #12
geerlingguy commentedFixed in 8.x, 7.x, and 6.x. Thanks for the sleuthing, drupoz, and congrats on your first commit on drupal.org! (see: https://drupal.org/u/drupoz).