Problem/Motivation

Sometimes the pasted comments are not in the expected place on the bottom of the thread.

Proposed resolution

When the 'flat comments' setting is choosen, the comments are sorting by it's cid column. If the comment id of the pasted comment is less then the cid of the comments in the node's comments hierarhy, the comment will appears on the top or in the middle of the existing comments, not on the bottom.

Remaining tasks

We need to change the drupal core sorting comments function to get rid of the sorting by cid.

Original issue submitted by ExTexan:

When I first tried this module, it seemed to work fine - that is, it moved the comments (and attached replies) as advertised. However, the last couple of times I've used it, the comments get cut, but not pasted.

The first time that happened, I had cut many comments, most of which had "reply-to" comments, so I thought, "Ok, that was too much for it."

Since then, I've tried cutting a single comment, but when I paste it, it's completely gone.

Also, if I'm remembering correctly, I read somewhere that this module is also supposed to allow for a topic (node) to be moved to a "comment" in another thread, but I can't figure out how to do so. Please advise.

Comments

extexan’s picture

This may or may not be related to my original post about dropped comments... While moving comments again today, it seemed they were being dropped because I was pasting them onto the last comment in the thread, but when I'd refresh, they didn't appear. Later, I found them posted earlier in the thread. They ended up in the thread *before* the latest comment I was pasting them onto.

The comment threading mechanism for pasting seems to be not working in all cases, though I can't pin down the circumstances where it does or doesn't work correctly.

nikita petrov’s picture

Category: Bug report » Support request
Status: Active » Postponed

ExTexan, there is the situation when the pasting comments will be displaying in the middle of the thread, not in the bottom. It will happens when you enabled a 'flat comments' setting and the cutted comments were created sooner then the comments in that thread. I don't think it is the natural and intuitive behaviour but there is nothing we can do here, because in that case the sorting runs by 'date' column, and we don't change the date of moving comments.
I hope that situation will be changed in Drupal 8 or someone will come up with theorethical solution how to solve it for Drupal 7. Thanks!

extexan’s picture

Thanks for that clarification, Nikita.

I did finally find the comments in the middle of the thread(s), as you described. Sorry I forgot to come back here and post an additional reply.

nikita petrov’s picture

ExTexan, no problem, actually you mentioned it in the previous comment. But it is not the obvious behavior and we should improve it sometime in the future, thank you for the pointing out the problem.

nikita petrov’s picture

Title: Cut/Paste Dropping Comments » Pasted comments are not on the expected place
Issue summary: View changes
nikita petrov’s picture

Title: Pasted comments are not on the expected place » Pasted comments are not in the expected place
Issue summary: View changes
nikita petrov’s picture

Title: Pasted comments are not in the expected place » Pasted comments sometimes are not in the expected place
nikita petrov’s picture

Issue summary: View changes
nikita petrov’s picture

Issue summary: View changes
nikita petrov’s picture

Title: Pasted comments sometimes are not in the expected place » 'Flat comments' setting issue: pasted comments sometimes are not in the expected place
nikita petrov’s picture

Version: 7.x-1.0-alpha2 » 7.x-1.0
Status: Postponed » Active
nikita petrov’s picture

  • Nikita Petrov committed c29da1b on 7.x-1.x
    Issue #2269753: Pasing comments at the bottom of the flat comments...
nikita petrov’s picture

Issue summary: View changes
Status: Active » Closed (fixed)

Fixed in the 7.x-1.1 release. Now we have an option on the admin page - a checkbox "Always add comments to the bottom of the thread when moving them to another node", default is TRUE.
When the style of comments is choosen as 'flat' and comments are moving from one node to another the cid of the comments would be changed and the inserted comments would appear at the bottom of the comments thread.