Hello
When I click chcekcbox override title, nothing happen. So i don't change title in book navigation. Then, when i save post and edit again, checkbox is unselect - but earlier i select it!

If you help me, i was very happy;-)

best regards

Comments

btopro’s picture

can you list some other projects you are using this with and if this is the latest dev? Haven't experienced this issue myself yet

floown’s picture

Hello,

I have the same bug with the beta4. I'll try the dev version to see if the bug is still here...

floown’s picture

Yes I can confirm, the beta4 version and the last dev version don't work. When I check the case, the area to change the title doesn't appear like in the screencast the page's module.

I'll try on a new D7 installation if I have some time.

floown’s picture

I have the same on a new Drupal 7 installation with the last version 7.x-1.0-beta4+3-dev

The beta4 doesn't work to.

floown’s picture

And now I have a notice : Notice : Trying to get property of non-object dans node_page_title() (ligne 2206 dans /var/www/drupal7.local/modules/node/node.module).

btopro’s picture

the content type you are expecting to see this on; if you go to admin/content/book/settings in your site is the type in question selected on that list as being allowed to be in an outline?

floown’s picture

StatusFileSize
new157.6 KB

In admin/content/book/settings here's I have on the screencaps.

btopro’s picture

Maybe this is an issue with international sites? There's nothing in the module doing anything with language based fields and I don't think title is translated but figure I'll ask -- are you running this on a site that's using multiple language / non english as the default? I use this on around 100 sites and it works consistently across D6 and D7 so I'm kind of at a loss as to it not working. Can you send me a screenshot of what the node form looks like when you try to click to override the title?

btopro’s picture

http://drupalcode.org/project/book_title_override.git/blob/refs/heads/7.... is the function that adds itself and the js to the page, also verify your not doing any strange form_alters.

floown’s picture

StatusFileSize
new64.88 KB

It's a Drupal 7 installed with english and french language. It's not a multilanguage site. I have try to switch to english and I have the same bug. See the screencaps.

floown’s picture

Ok I have installed a very new Drupal 7.27 with standard modules enabled. Then I have installed to module Book Title Override. The area to change the title now appear when I check, but the choice is not saved with the node. The title override is not affected. I my book nagator I have an emply entry (not listed, I mean).

I have retry Book Title Override beta4. I now I test with the last dev (january). Stay tuned :)

floown’s picture

Sorry, the beta4 works, I have forgot to check the creation of a new book. I'll try now on my production site if I can have the same.

floown’s picture

Ok I have found when I have the bug ! There is a problem with jQuery Update. When I install it, the checkbox doesn't work no more. I'll try now with the dev of this module.

floown’s picture

jQuery update does not work with your module from the 1.7 version.

I must enabled it for having responsive menu with Menu style.

So I can not use our module for this time, until you patch it. Thanks!

btopro’s picture

Status: Active » Closed (works as designed)

Use the latest version of jquery update, then go to the settings for it and pick whatever for the front end, then set the admin version to use to 1.5. This is a common problem w/ jquery and drupal

floown’s picture

I have said that I must use the 1.7 version for using another module.

btopro’s picture

you need to use responsive menu style on the administration side of the site?

floown’s picture

StatusFileSize
new13.26 KB

Look.

Where can I specify the 1.5 only for admin ? oO
I thought I can only affect all the site.

Could you give me the path to the menu please?

floown’s picture

Sorry I have found the option. I test if your module works now.

floown’s picture

Cool it works now! Thx!

ladybug_3777’s picture

How can this be closed and marked as "Works as designed"? The module should be updated to fix the bug it has with newer versions of jQuery, the newest version is 1.10 and many modules (admin side) will not work with the old outdated 1.5 version. I'm going to re-open this issue and look into creating a patch.

ladybug_3777’s picture

Status: Closed (works as designed) » Active
btopro’s picture

Component: Code » User interface
Assigned: zastapmnie » Unassigned

Open said issue with Views / Ctools as well then cause that won't work without old outdated jQuery as many Admin projects don't :) I don't disagree with you at all, it was just a solution at the time. A patch would be accepted so long as it still works with older versions of jQuery as well, especially since jquery_update now supports a defined version for admin pages and a defined version for the rest of the site (included core jQuery 1.4.x up through 1.11 I think).

Please do submit a patch though I'll gladly accept it if it works.

ladybug_3777’s picture

Found the fix, patch coming up

ladybug_3777’s picture

Patch is attached. The issue was related to the use of the .attr function. It no longer works in jquery 1.6 and up. To remedy this I used the more standard jquery check for checking if a checkbox is checked using the .is(':checked') property. This will allow the script to function in the older versions of jQuery along with the newer versions.

Please give it a try!

ladybug_3777’s picture

Status: Active » Needs review
ladybug_3777’s picture

I just realized I didn't check the .js for Outline Designer and it has the same problem. Re-rolling patch to include that fix as well. New patch coming up!

ladybug_3777’s picture

New patch. This is the same as the patch in #25 but it also includes a fix for the book_title_override_ops.js file used in Outline designer.

UPDATED to add NOTE: Outline designer I'm noticing also has some issues with the newer versions of jQuery so it's kind of buggy on it's own. That being said the fix for the outline designer issues may need more work.

Please try out this new patch, thanks!

btopro’s picture

Looks legit, simple, make sense, and extra coudos for working on the outline designer side of things too That project def needs some love in the forward compatibility of jQuery for sure.

Still needs review but this looks correct.

  • btopro committed 9ade689 on 7.x-1.x authored by ladybug_3777
    Issue #2238139 by floown, ladybug_3777: Checkbox override title is not...
btopro’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.