Closed (fixed)
Project:
TraceView
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
4 Apr 2014 at 18:17 UTC
Updated:
16 Jun 2014 at 16:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hefox commentedComment #2
hefox commentedwrong path
Comment #3
shivar commentedThe patch works for me. The only change I made was replace the first line with:
diff --git a/sites/all/modules/traceview/traceview.drush.inc b/sites/all/modules/traceview/traceview.drush.inc
Thanks!
Comment #4
hefox commentedWhy did you change issue status to "Active"? If patch needs work, "needs work", but as far as I can tell this doesn't need work -- the patch from comment 2 has the correct patch from module root.
Comment #5
blazindrop commentedI am experiencing a similar error, but not for this function. Since traceview_set_partition() is wrapped with a condition on the variable traceview_partition_drush_traffic existing, I wonder if you have this variable set to a non-false value even though your module is off.
In my case I don't have any traceview variables and the error I get is:
The code for this function call doesn't have any conditions around it so it will run regardless if the module is enabled or not. The big question is, when is it appropriate to call traceview_set_attributes()? Attached is my patch. This was tested locally. One reason I'm not using module_enabled() for the condition is performance.
Comment #6
Eronarn commentedA better solution for this would be to move the partitioning/controller/reporting functions out of traceview.module and into traceview.inc so that they can also be included during a Drush run. After all, you still want to report a partition for those drush requests!
Comment #7
Eronarn commentedComment #8
pdrake commentedComment #9
pdrake commented