Code Review analysis

I ran coder (code review) and it reported these issues, none of which appear to be important.

Line 3: New syntax for .info files, use dependencies[]

dependencies = search

severity: normalLine 14: string concatenation should be formatted without a space separating the operators (dot .) and a quote

      $output .= '<p>'.  t("OpenSearch provides browser search integration via the OpenSearch plugin protocal."). '</p>';

severity: normalLine 14: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms

      $output .= '<p>'.  t("OpenSearch provides browser search integration via the OpenSearch plugin protocal."). '</p>';

severity: normalLine 60: Functions should be called with no spaces between the function name

  $form['image'] = array (

severity: normalLine 66: Functions should be called with no spaces between the function name

  $form['image']['opensearchplugin_image'] = array (

severity: normalLine 72: Functions should be called with no spaces between the function name

  $form['image']['opensearchplugin_image_width'] = array (

severity: normalLine 78: Functions should be called with no spaces between the function name

  $form['image']['opensearchplugin_image_height'] = array (

severity: normalLine 108: Control statements should have one space between the control keyword and opening parenthesis

  if(empty($icon)) {

severity: normalLine 111: Control statements should have one space between the control keyword and opening parenthesis

    if(!empty($icon))

severity: normalLine 112: curly braces { should end a line, not start one

    {

severity: normalLine 115: string concatenation should be formatted without a space separating the operators (dot .) and a quote

      $icon = $url['scheme'] . '://' . $url['host'] . $icon;

severity: normalLine 119: Control statements should have one space between the control keyword and opening parenthesis

  if(!empty($icon)) {

severity: normalLine 122: string concatenation should be formatted without a space separating the operators (dot .) and a quote

    $icon = '<Image' . $iconwidth . $iconheight .'>'. $icon. '</Image>';

severity: normalLine 122: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms

    $icon = '<Image' . $iconwidth . $iconheight .'>'. $icon. '</Image>';

severity: normalLine 127: string concatenation should be formatted without a space separating the operators (dot .) and a quote

  $output = '<?xml version="1.0" encoding="UTF-8"?'. ">

I changed the .info file to the following. This is due to the note here: http://drupal.org/node/114774#info .. the module appears to work properly.

; $Id: opensearchplugin.info,v 1.1.4.1 2007/10/14 01:13:43 robloach Exp $
name = OpenSearch Plugin
description = Provides browser search integration via the OpenSearch plugin protocal.
dependencies[] = search
core = 6.x

; Information added by drupal.org packaging script on 2007-10-14
version = "6.x-1.0"
core = "6.x"
project = "opensearchplugin"
datestamp = "1192324805"