Hello,

Thanks for the great module!

I use version 7.x-3.0-rc2. I have many different images with different repeated text in Russian. For example: "Скидка 10%", "Бесплатная доставка!", "Подарок к заказу" etc.

I get files in textimage directory:
Скидка 10%.png
Бесплатная доставка!.png
Подарок к заказу.png

But each text superimposed on different images. Files should be more.
As a result, I get the wrong images (images from other nodes) in my Views

Please add the unique identifier for the file name (FID). And transliteration filenames.

Sorry for bad english.

CommentFileSizeAuthor
#3 textimage_image-formatter-bug_2217313-3.patch2.63 KBmondrake
#2 001.png103.8 KBsashken2
#2 002.png57.38 KBsashken2
#2 003.png78.84 KBsashken2

Comments

mondrake’s picture

mondrake
Location 🇮🇹
commented

Hi @sashken2, thanks for your appreciation!

Very difficult to understand what's going on from your report. Can you please try to describe in as many details as possible the steps to reproduce the problem?

How are you using the module (via field formatters, URL, theme calls, API), what did you do to configure, examples...

sashken2’s picture

sashken2 commented
StatusFileSize
new 003.png78.84 KB
new 002.png57.38 KB
new 001.png103.8 KB

I have a different image with the same text. And each image with the text to be created separately.
Now every text is created only one image.

The screenshots of my settings.

You can see my site: http://skidki-akcii.ru/
http://skidki-akcii.ru/promokody
http://skidki-akcii.ru/akcii
After clicking on the node title, you will see the actual picture.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new textimage_image-formatter-bug_2217313-3.patch2.63 KB

I think I understand. The problem is that if you have an Image field formatted via Textimage, and multiple nodes with same text but different images, then all the textimages will have the same filename, and so you lose the starting image background.

This can be solved by forcing the filenames to be hashed - the hash also takes the original FID in its calculation.

Can you test this patch? (you will have to flush caches and probably delete all Textimages too)

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Please add a unique identifier in the file name » Filename collisions in the field formatter for Image fields
Version: 7.x-3.0-rc2 » 7.x-3.x-dev
Priority: Critical » Major

Changed issue title and priority.

sashken2’s picture

sashken2 commented

mondrake, thank you!!!

I test this patch, and all works good. You can see it on my site.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community
mondrake’s picture

mondrake
Location 🇮🇹
commented

Good, I will commit it to the dev branch then.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Fixed

Committed 3ecf19e and pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.