There are quite a few warnings currently at http://pareview.sh/pareview/httpgitdrupalorgprojectpmgit-7x-1x .

Whilst most are minor, resolving these will help make more serious issues more obvious.

CommentFileSizeAuthor
#15 pm_pareview_readme_2x-2215477-9167579.patch5.18 KBdbt102
#12 pm_pareview_readme-2215477-9167461.patch5.49 KBdbt102
#1 pm-pareview-spelling.patch1.99 KBjuliangb
#1 pm-pareview-css.patch11.02 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Assigned: Unassigned » juliangb
Status: Active » Needs review
StatusFileSize
new pm-pareview-css.patch11.02 KB
new pm-pareview-spelling.patch1.99 KB

Two initial patches covering specific parts of the codebase.

I have tried to focus on areas that are unlikely to cause merge conflicts.

Neither patch should affect module functionality at all.

juliangb’s picture

juliangb commented
Status: Needs review » Active

Two patches from #1 committed to 7.x-1.x.

  • Commit 603f0c1 on 7.x-1.x by juliangb: 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • Commit 603f0c1 on 7.x-1.x, 7.x-2.x by juliangb: 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.
  • Commit 8b93609 on 7.x-2.x by juliangb:
    Merge branch '7.x-1.x' into feature/pmperson

* 7.x-1.x:
Issue #2221977...

  • juliangb committed bbfe3f0 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed c1754b9 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 8de88bc on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.
dbt102’s picture

dbt102 commented

Can I help w/ this cleanup? Thinking I'd just grab a file and do what I can, then post it up as a patch?

d34dman’s picture

d34dman commented

That would be a great way to get started with development part of this project. But please note that we are now working on 7.x-2.x part of the project. And let us know which part you are working on so we don't duplicate our efforts.

juliangb’s picture

juliangb commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

Good point - these changes should be made on the 2.x branch.

Also, when looking at http://pareview.sh/pareview/httpgitdrupalorgprojectpmgit-7x-2x, I suggest selecting the "repeat review" option after each commit so that all the warnings / errors are shown correct and associated with the correct line numbers.

dbt102’s picture

dbt102 commented

Ok, will start with README.txt to get started on a workflow.

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
dbt102’s picture

dbt102 commented
StatusFileSize
new pm_pareview_readme-2215477-9167461.patch5.49 KB

  • juliangb committed fc19614 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.
dbt102’s picture

dbt102 commented

Hmmm... something doesn't look right...

http://pareview.sh/pareview/httpgitdrupalorgprojectpmgit-7x-1x reports

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 90 characters

http://pareview.sh/pareview/httpgitdrupalorgprojectpmgit-7x-2x reports

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES

Did the changes get applied to pm_7x_1x somehow? I'll submit readme_2x patch in a minute. No big deal, just want to make sure I understand my workflow well as I get started.

dbt102’s picture

dbt102 commented
StatusFileSize
new pm_pareview_readme_2x-2215477-9167579.patch5.18 KB

  • juliangb committed d3a47b3 on 7.x-2.x authored by dbt102 
    Issue #2215477 by dbt102, juliangb: Cleanup: Resolve pareview.sh...
juliangb’s picture

juliangb commented

For some reason the patch isn't applying properly to 1.x, but the 2.x one did and I've committed it. Thanks!

  • juliangb committed 88fe350 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 5f5fdd7 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed e35fd63 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 49ea233 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 7424287 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed e809163 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed ee06579 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 733eb93 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 28adf69 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 2245c63 on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed c6bc5bf on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.

  • juliangb committed 2d7834f on 7.x-2.x 
    Issue #2215477 by juliangb: Cleanup: Resolve pareview.sh warnings.
juliangb’s picture

juliangb commented
Status: Active » Fixed

I think we've got this done as much as is necessary.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.