Hi
I made new version of Back To Top module for Drupal 8.
Could you please review my code?

CommentFileSizeAuthor
#3 back_to_top-drupal-8-version-2203165-3.patch37.18 KBshkiper
back_to_top.zip18.25 KBshkiper

Comments

acke’s picture

acke commented
Status: Active » Needs review

Thanx! I try to check it out in as soon as possible.

estoyausente’s picture

estoyausente
Primary language Spanish
commented

Suscribe, if you create a new branch for this version, I try to help :-)

shkiper’s picture

shkiper commented
StatusFileSize
new back_to_top-drupal-8-version-2203165-3.patch37.18 KB

Here is the patch to port Back To Top module to Drupal 8.

acke’s picture

acke commented

I'll try to review this code during the summer. Look good at a quick glance.

  • acke committed 2f336f0 on 8.x-1.x authored by andrii zahura 
    Issue #2203165 by andrii zahura, acke: Port Back To Top to Drupal 8.
acke’s picture

acke commented
Status: Needs review » Closed (fixed)

Great work andrii! I tried the 8.x version and I found the syntax for including libraries had changed so to get the easing effect easeOutQuart working I changed

drupal_add_library('system', 'jquery.effects.core');
or:
$page['#attached']['library'][] = array('system', 'jquery.ui.effects.core');

to:

$page['#attached']['library'][] = 'core/jquery.ui.effects.core';

It's committed to the intital 8.x-1.x and I made this the 8.x-1.0-beta1 release.