One thing I immediately missed from this module was the ability to open windows in a new window (like the other module could). So here's a patch implementing it.

There's one issue though, if I toggle the new window option I don't see the effects immediately, I have to clear the cache_filter table in order to see the results.

Disclaimer: I'm a PHP newbie and I'm codewise not really familiar with Drupal, but it works for me :)

CommentFileSizeAuthor
newwindow.patch1.08 KBbram85

Comments

manuel garcia’s picture

manuel garcia commented

Thanks for the patch, I also missed this very important feature in this module.

Hopefuly it will be included in the next version soon, after it gets reviewed :)

m3avrck’s picture

m3avrck commented
Status: Active » Fixed

Thanks!

I've committed a different version of this same option: http://drupal.org/cvs?commit=97822

It uses jQuery to open external links in a new window, which degrades nicely if a user has no JS. Based on this technique (but I updated it to use jQuery): http://www.sitepoint.com/article/standards-compliant-world/3

manuel garcia’s picture

manuel garcia commented

Outstanding! I will be using this module now - many thanks to you both!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.