The default links extension do not handle Mac/Linux line endings "\n\r". This patch will fix this using the same trick as the core list field module uses.

This patch also adds validation of the input pattern in the default links configuration form.

CommentFileSizeAuthor
#3 og_menu_default_links-2140853-3.patch6.7 KBcableman0408
#1 og_menu_default_links-2140853-1.patch6.05 KBcableman0408

Comments

cableman0408’s picture

cableman0408 commented
Status: Active » Needs review
StatusFileSize
new og_menu_default_links-2140853-1.patch6.05 KB
rv0’s picture

rv0 commented

It's a feature/module I never use myself..
Patch seems good, one small remark, watchdog messages cannot contain dynamic values.
https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/watc...

So the statement you are improving on line 94 could use some more improvement.

cableman0408’s picture

cableman0408 commented
StatusFileSize
new og_menu_default_links-2140853-3.patch6.7 KB

You are totally right :-) and I have updated the patch with a fix for the watchdog statement.

rv0’s picture

rv0 commented
Status: Needs review » Fixed

Committed.. I feel it will be time for a new RC version release soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.