Please add this text or similar to the module home page:

WARNING: the user admin page provided by this module offers to delete - not cancel - user accounts. The crucial difference is that deleting a user account will also delete the nodes authored by that user, whereas cancelling a user account will first check the core "method for cancelling user accounts" setting, which is much safer because it contains an option to keep the content.

CommentFileSizeAuthor
#12 admin_views-replace_delete_with_cancel-2125683-12.patch1.29 KBrooby
#9 admin_views-replace_delete_with_cancel-2125683-9.patch844 bytesjohn bickar

Comments

joshbotnet’s picture

joshbotnet commented
Issue summary: View changes
damiankloip’s picture

damiankloip commented

I would take this up with vbo.

matthewn’s picture

matthewn commented

Related vbo issue: https://drupal.org/node/1799484

joelcollinsdc’s picture

joelcollinsdc commented
Title: Warning: Delete != Cancel user account » Replace delete user with cancel user action

Since #1885294: Show warning when deleting user new has landed, we now need admin views to highlight the cancel vbo instead of the delete vbo for users

damiankloip’s picture

damiankloip commented

ok, so we just want a patch now that switches the delete action for the cancel action?

joelcollinsdc’s picture

joelcollinsdc commented

Not sure i'm the authority on this but it seems the delete user should not be exposed, its too dangerous.

bojanz’s picture

bojanz commented

I've tagged VBO 3.2, so there's now a stable release with the cancel action included. Just enable it by default, and disable the delete one.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented

+1 for #6, delete shouldn't be exposed at all

john bickar’s picture

john bickar commented
Status: Active » Needs review
StatusFileSize
new admin_views-replace_delete_with_cancel-2125683-9.patch844 bytes

Patchy attachy.

john bickar’s picture

john bickar commented

The "cancel user account" action is only available as of views_bulk_operations-7.x-3.2; not sure if you want a patch that indicates that in the .info file for admin_views or not.

sherakama’s picture

sherakama commented
Status: Needs review » Reviewed & tested by the community

Patch is good. Sends the user to the options page instead of deleting everything. Simple but huge UX improvement.

Thanks,

rooby’s picture

rooby commented
StatusFileSize
new admin_views-replace_delete_with_cancel-2125683-12.patch1.29 KB

As mentioned in #10 we should specify a minimum VBO version.

This patch does that.

Maybe it is also worth a hook_update_N() with a message in it to the user to inform them that if they are using an overridden view it is recommended they change to the cancel operation.

damiankloip’s picture

damiankloip commented

I think we can go for this as -is for now. If people have overridden a view, they are on their own so to speak. I think I put a note about that on the project page too.

I was going to suggest the dependency update too - but you already took care of that :)

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-1.x

  • Commit 94562d1 on 7.x-1.x by damiankloip: 
    Issue #2125683 by rooby, John Bickar | joshmelbs: Fixed Replace delete...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.