How can I get video to work? I'm using the media module.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | royalslider-vimeo_and_fixes-2122137-14.patch | 3.41 KB | tim_dj |
| #6 | royalslider-vimeo_and_fixes-2122137-6.patch | 3.4 KB | tim_dj |
| #2 | royalslider-video-2122137-2.patch | 5.26 KB | thijsvdanker |
| #1 | royalslider-video-2122137-1.patch | 4.04 KB | thijsvdanker |
Comments
Comment #1
thijsvdanker commentedI've made a first stab at supporting some video, but it's limited (to your usecase ;))
It supports Youtube video's, and uses hqdefault.jpg thumbnail for the video (see http://stackoverflow.com/questions/2068344/how-to-get-thumbnail-of-youtu...)
What still needs to be done:
- support Vimeo
- cleanup the code
and maybe as another issue:
- support a custom thumbnail (other image field?) to be used instead of the youtube/vimeo thumb.
@tchopshop, can you give it a spin?
Comment #2
thijsvdanker commentedSmall cleanup that removes a notice.
Comment #3
tchopshop commentedThat worked!!! Thank you so much!
Comment #4
thijsvdanker commentedThe patch in #2 is committed to dev, but I'll leave this issue open until the code is cleaned and Vimeo support is added.
Comment #5
thijsvdanker commentedComment #6
tim_djThis module didn't work for me. It required a file display 'node' for video which I did not have. I've changed this to 'default' in this patch.
I saw that you create the youtube thumbnail by requesting a url from youtube. This is unnecessary because media_youtube module already grabs the thumbnail and saves this locally.
Also I've added Vimeo support. (basically copied the youtube code and created Vimeo code) I think this should be rewritten to a more generic solutions.
Please test if it works for you as well (since i've changed the display mode)
Comment #7
tim_djJust spoke with Thijs and he added custom youtube image code because media_youtube does not always get the highest quality. This is an issue of media_youtube however and is already being worked on see media_youtube issue #1893388 so we have to live with low quality for a little while longer or apply the patch for media_youtube
Comment #8
thijsvdanker commentedI will leave the highres thumbnail in the royalslider module until media_youtube has figured it out.
Comment #9
thijsvdanker commentedAh there already is a patch up in #1893388 ready to be reviewed. If anyone can confirm that the patch works, I'll remove the code from rs!
Comment #10
tim_djPatch works perfect, although not easy to apply. I've updated patch at media_youtube #1893388 and is ready for review.
@thijsvdanker If you want to hold off patch #6 because of this I can re-add youtube code?
Comment #11
drewww commentedIs it true that integrating video content for RoyalSlider will only work when using Views (Slideshow)? I can't seem to get it to work using fields. It seems that I have both an Image field AND a File field, which would not combine within the RoyalSlider thus not be possible. What am I doing it wrong? Is there a way to have both media types in one field? Obviously the Media field handles images and styles, but they are only received from the video. Please note that I have successfully gotten fields to output a RoyalSlider using an Image field, and simply tried to add a Media field to the content type with rendered file selected, and proper file format settings (Default and Preview). Any help is greatly appreciated! –Andrew
Comment #12
thijsvdanker commentedHi Andrew,
That is indeed true (video content only working with views implementation at this moment).
The way to support this on fields to would be to support file_entitiy's file field.
At this moment it only supports the 'image' field.
I've created a separate issue for video/file_entity support for fields here https://drupal.org/node/2151239
Comment #13
thijsvdanker commented@timdj: no, what's keeping me from committing is finding some time between writing 'gedichtjes' to patch both modules and give it a serious test :)
Is it keeping you from moving on?
If anyone else (besides the patch creator) can give it a shot, that's fine with me.
Comment #14
tim_djNo not keeping me from moving on, I am just using the patched code. Anyway I found a small notice both in original and my latest patch, so here is a revised patch
Comment #15
thijsvdanker commentedFinally came around to testing your patches (this one and the youtube one).
So as a birthday gift, I've committed your patch to dev! (http://drupalcode.org/project/royalslider.git/commit/74a84e2) :)