Closed (fixed)
Project:
OpenFed
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
24 Sep 2013 at 11:34 UTC
Updated:
23 Jun 2014 at 22:09 UTC
Jump to comment: Most recent
Comments
Comment #1
Delphine Duprez commentedBald, fine with me.
Comment #2
bald.herreman commentedover to babou then
Comment #3
Babou commentedComment #4
bart.hanssens commentedComment #5
bald.herreman commentedNOK on minifed. Can you check?
http://minifed.rovin.be/nl/nieuws
Comment #6
bart.hanssens commentedComment #7
Babou commentedForgot to mention that a
drush rdss ofed_newsis required as we have changed the Display Suite settings.Comment #8
bart.hanssens commentedHmz ok, done on langfed and minifed, but I was expecting that such a change would be performed automatically using an
hook_update()Comment #9
Babou commentedI think it's better to keep using the drush command for this kind of issues as a hook_update will simply override any changes a builder could have make to the Display suite settings it you need to run the update script on their site.
Here it has to be done manually but it ensure that you do not override the display suite settings when you have to update something else on the site like a contrib module.
Comment #10
bart.hanssens commentedOk, sounds reasonable, but is there a way to do a
drush rdsson _all_ content types, instead of just one ?Just like
drush fradeals with reverting all features ?That would make updating straightforward (just tell the admin to always run
drush cc all; drush fra -y ; drush rdss --allor something along those lines)Comment #11
Babou commentedWell, as it is implemented right now, it deletes the settings for the given content types then it inserts the new version instead of updating them.
The process doesn't check whether or not the submitted content type has been modified and assume you know what you are doing when you run the command.
So long story short, the command will completely replace the settings for the given content types, there is no merge or anything. It's quite a dumb function and it is not recommended to replace the settings all at once.
It can be implemented if needed but keep in mind that any changes will be replaced.
Comment #12
bart.hanssens commentedAh so it is a custom
openfed.drush.incscript... that's not good...Updating really has to be straightforward, as sites are starting to move to production, we can't afford having to run separate (custom) scripts when switching versions (because, as you've noticed, it's easy to miss a script...)
Doesn't
Display Suitesupport theFeaturesmodule / could Features be used to solve this ?Comment #13
Babou commentedWhen I first started working on OpenFed, I was told that the display suite settings were always read from the feature and not from the database. So whatever the changes, when you were going to display a node, Drupal was always going through the featured settings instead of the one stored in the database to render the node.
Meaning, that it just good for deploying a content type but once you want to change something, it was no longer an option to keep the feature enabled.
Hence the fact that now, the display suite settings are stored in an install folder in our feature and prefixed with an underscore. The file is included during the installation of the feature so it loads the DS settings.
And even if it works now with the latest version of Features, running a
drush fra -ywill revert everything anyway and do the exact same thing.Comment #14
bart.hanssens commentedOK for now, probably a more detailed analysis / procedure is required for future releases