This module requires the PHP extension SOAP to be installed on the web server.

However, there is no mention of this requirement anywhere, and the SoapClient class (provided by the extension mentioned above) is just being called, without checking for its existence beforehand. This results in a WSOD if the extension is not installed.

CommentFileSizeAuthor
#1 vat_number-2073743.patch1.21 KBroball

Issue fork vat_number-2073743

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roball’s picture

roball commented
Status: Active » Needs review
StatusFileSize
new vat_number-2073743.patch1.21 KB

The attached patch fixes this problem.

dwkitchen’s picture

dwkitchen commented
Assigned: Unassigned » dwkitchen
Status: Needs review » Needs work

I have committed, but marked as still needs work as I think a hoor_requirements in an install file would also cover this.

roball’s picture

roball commented
Category: bug » feature
Priority: Major » Normal

Thank you for the commit. Yes, I agree that checking this requirement in hook_requirements should be done in addition to the check before actually calling the extension's function.

However, since the second mentioned check is now in Git, I think this issue can be changed from a bug report to a feature request.

dieterholvoet’s picture

dieterholvoet commented
Version: 7.x-1.x-dev » 2.0.x-dev
Issue summary: View changes
dieterholvoet’s picture

dieterholvoet commented
Assigned: dwkitchen » Unassigned
dieterholvoet’s picture

dieterholvoet commented

It would probably be a good idea to add a hook_requirements implementation that checks if the extension exists using extension_loaded(), just like system_requirements() does.

dieterholvoet’s picture

dieterholvoet commented
Title: Before calling the 'SoapClient' class, check if it actually exists, and print an error on mising PHP SOAP extension » Validate whether the PHP SOAP extension is enabled

dieterholvoet opened merge request !10

dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Needs review

  • dieterholvoet committed f6378408 on 2.0.x 
    Issue #2073743 by dieterholvoet, roball, dwkitchen: Validate whether the...
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.