On the account page, below the file upload field for the account image, is a checkbox: "If you have a valid Gravatar associated with your e-mail address, use it for your user picture." The description below the checkbox: "Your Gravatar will not be shown if you upload a user picture."

This works correctly with just Gravatar, but Gravatar Style ignores the uploaded user picture and tries to request an image from Gravatar.

I think that this can be corrected by checking the return value from _gravatar_get_account_user_picture(): if it's a Gravatar URL, then Gravatar Style should do its thing: check for a cached image, request a new one if necessary, etc. If it's a local file path, that filepath should be used as-is.

I'm working on a patch to this.

Comments

BrockBoland’s picture

Status: Active » Needs review
StatusFileSize
new2.18 KB

Patch attached. Check if the filepath from _gravatar_get_account_user_picture() is a local file path, and if so, don't do anything with Gravatar.

cafuego’s picture

Status: Needs review » Fixed

Inspected and applied patch, looks good.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.