Multiform used by media module doesn't create a div wrapper for the submit buttons with "edit-actions" Id, that Sticky Edit Actions is using to add sticky functionality.

Comments

binkaster’s picture

StatusFileSize
new1.3 KB

Attached is a patch for this issue.

elijah lynn’s picture

removing tag

binkaster’s picture

Status: Active » Needs review
binkaster’s picture

StatusFileSize
new1.11 KB

Corrected the patch file according to Drupal formatting standards.

binkaster’s picture

StatusFileSize
new1.01 KB

Fixed the patch (run the patch creating command form the correct folder with --relative).

elijah lynn’s picture

+++ b/sticky_edit_actions.moduleundefined
@@ -27,3 +27,17 @@ function sticky_edit_actions_form_alter(&$form, &$form_state, $form_id) {
+/**
+ *
+ * Implements hook_media_edit_multipe_form_alter().

There is a typo here and an extra blank line above the comment. *multiple

elijah lynn’s picture

Status: Needs review » Needs work
binkaster’s picture

Status: Needs work » Needs review
StatusFileSize
new1.02 KB
binkaster’s picture

StatusFileSize
new1.01 KB

Removed the blank line from the patch.

elijah lynn’s picture

Status: Needs review » Reviewed & tested by the community

This is great! I will commit this and make a new release as soon as we get the alter hook committed to Media in
#2067091: Sticky Edit Actions doesn't work with the Media module's multiform "Save" and "cancel" buttons.

elijah lynn’s picture

There is also the possibility that #2065525: Use 'actions' for buttons will get fixed and if it does then we won't need this patch but I have a feeling this will get added way before then.

elijah lynn’s picture

elijah lynn’s picture

Status: Reviewed & tested by the community » Fixed

Committed - http://drupalcode.org/project/sticky_edit_actions.git/commit/be533576e1f...

This will be in the upcoming 7.x-1.1 release (as soon as D.O releases are fixed) as the new hook/patch has been committed to Media module. It will require media-7.x-2.0-alpha2 or later to work with multiform.

elijah lynn’s picture

I actually referenced the wrong #issue in the commit message so I reverted it and made a new commit here with the right #issue.

http://drupalcode.org/project/sticky_edit_actions.git/commit/3f83ba6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

elijah lynn’s picture