It says

"This module disables the "Username" field on user registration and user edit forms"

on the modules page, but the username field is still showen on the edit page.

CommentFileSizeAuthor
hide_username.patch559 byteshydra

Comments

alexkb’s picture

Issue summary: View changes

Thanks Hydra. Not sure how I or anyone else didn't pick up on this already! Have now applied your patch. Welcome to the comitters list. :)

alexkb’s picture

Status: Needs review » Closed (fixed)
jibus’s picture

Status: Closed (fixed) » Needs work

Re-open,

I think, it's better to leave it as an option.

For my case, i have some roles where the auto username does not apply (thanks to the hook_auto_username_name, see https://drupal.org/node/261211).

Two options :

- Add a option which allows the administrator to decide whether or not the filed should be hidden in profile page. The module Automatic Nodetitles works this way for example.
or
- Revert, and let the user implement the hook himself in a custom module.

What do you think ?

hydra’s picture

Status: Needs work » Closed (fixed)

Since this is part of the modules description, I would not recommend to leave this as an "implement it on you own" option ;) Thats what contrib modules are for. However the proposal to add an option to disable this in particular use-cases, would be drupal-like.

@Jibus: Please open a new issue for that nad provide a patch if you worked already on this. Would be pleased to review :) This issue here is closed.
@alexkb: Thx for commiting :)