Author instructions for installing the SimplePie plugin for Feeds XML parser. The current instructions are incomplete.

CommentFileSizeAuthor
#24 feeds-simplepie-install-docs-2038525-24.patch1.15 KBtwistor
#23 feeds-simplepie-install-docs-2038525-23.patch1.24 KBtwistor
#19 simplepie-install-documentation-2038525-3.patch1.59 KBlarsdesigns
#15 simplepie-install-documentation-2038525-3.patch1.59 KBlarsdesigns
#14 feeds-n2038525-14.patch1.77 KBDamienMcKenna
#7 simplepie-install-documentation-2038525-2.patch1.59 KBlarsdesigns
#1 simplepie-install-documentation-2038525.patch1.59 KBlarsdesigns
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented
FileSize
simplepie-install-documentation-2038525.patch1.59 KB

I carefully authored instructions for the installation of SimplePie and updated the README.txt file accordingly. Please see the attached patch.

markwk’s picture

markwk CreditAttribution: markwk commented

Thanks! This solved my problem. This would be good to add to a readme somewhere or at least somewhere in the project page. Kind of had to search to find :(

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

I am glad I could be of help. Unfortunately, this has gone under the radar.

jbrown’s picture

jbrown CreditAttribution: jbrown commented

I think it would be better to add to to the online documentation: https://drupal.org/node/622696

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

I feel like it would be nice to have the instruction available to the Advanced Help module.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Active » Needs work

There is trailing whitespace after "following steps:"

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented
Status: Needs work » Needs review
FileSize
simplepie-install-documentation-2038525-2.patch1.59 KB

I have cleaned up the line ending and removed the extra white space. The updated patch is attached.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

If the patch is accepted, I would like to update the online documentation also.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented
Status: Needs review » Reviewed & tested by the community

Changing the status after it has been reviewed by a couple community members.

twistor’s picture

twistor CreditAttribution: twistor commented

Eek, is that the required process? We should make that simpler.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

That is the current install process. It would be helpful to add the documentation because of the complexity. Perhaps in a future release the process can be made simpler.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented

You can always also grab the most recent version of the compiled file from http://dev.simplepie.org/SimplePie.compiled.php.
That may be a bit easier for folks who need to use the README.

Thanks for all the work on this @larsdesigns :)

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

Wow, three months for a documentation commit?

At least folks have been referencing the issue for documentation.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Assigned: larsdesigns » Unassigned
Status: Reviewed & tested by the community » Needs review
FileSize
feeds-n2038525-14.patch1.77 KB

I reformatted the patch and made a few small improvements to make it easier to read, and fixed one or two typos.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented
FileSize
simplepie-install-documentation-2038525-3.patch1.59 KB

Fixed on or two typos and reformatted the patch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

The patch in #15 doesn't include any of the readability improvements from #14 and looks exactly the same as the patch in #7.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

The patch in comment #14 left out important instructions. If there are problems with the patch on #15, please point them out specifically.

twistor’s picture

twistor CreditAttribution: twistor commented
Issue summary: View changes
Status: Needs review » Needs work

Can someone sort this out?

I'd love to commit it.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented
FileSize
simplepie-install-documentation-2038525-3.patch1.59 KB

@twister, The patch seems super clear to me. After eight months of sitting in the issue queue without any movement or specific improvement requests, I would recommend making the commit.

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

Here is another option to install SimplePie library. Simplified by using the compiled version at https://www.drupal.org/node/2388663

Those instructions are for ERPAL module but it's probably the same instructions for Feeds module?

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

Is there a specific reason why the patch in #19 will not be committed?

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz commented
Status: Needs work » Needs review

@larsdesigns
Someone has to review the patch and confirm that the new instructions are clear.
Setting status to "Needs review".

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
FileSize
feeds-simplepie-install-docs-2038525-23.patch1.24 KB

There's no reason to compile the download, we can use the autoload already.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
FileSize
feeds-simplepie-install-docs-2038525-24.patch1.15 KB

The status report business is no longer relevant.

arnoldbird’s picture

arnoldbird CreditAttribution: arnoldbird commented

I followed the docs in twistor's patch, but feeds is not recognizing simplepie, I don't think. Do the instructions apply to the alpha9 version of Feeds?

I cleared Drupal's cache twice, but am still seeing this error...
Missing Feeds plugin FeedsSimplePieParser. See news_cred_1. Check whether all required libraries and modules are installed properly.

In the "Select a Parser" section of my feeds, simplepie is no longer an option.

The file perms and ownership of the simplepie directory are the same as for my other libraries.

The instructions suggest using SimplePie 1.3. Does that include 1.3.1, in this case? I installed 1.3.1.

arnoldbird’s picture

arnoldbird CreditAttribution: arnoldbird commented

Yes, twistor's instructions do work in the dev release. I tested. The SimplePie option appears once again in the list of parsers, and the radio button is selected.

  • twistor committed e7f7f39 on 7.x-2.x 
    Issue #2038525 by twistor, larsdesigns, DamienMcKenna: SimplePie Plugin...
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

larsdesigns’s picture

larsdesigns CreditAttribution: larsdesigns commented

Ridiculous...

drupal a11y’s picture

drupal a11y CreditAttribution: drupal a11y as a volunteer commented

A guide on Drupal.org within the Erpal documentation: https://www.drupal.org/node/2388663