When user submits a correct answer, captcha module stores $_SESSION['captcha_success_form_ids'][$form_id] unconditionally. This disables page cache for current user.

CommentFileSizeAuthor
#3 captcha-2021759-3.patch928 bytesolli
#1 captcha-2021759-1.patch1.06 KBolli

Comments

olli’s picture

olli commented
Status: Active » Needs review
StatusFileSize
new captcha-2021759-1.patch1.06 KB

This patch stores form id in session only if persistence mode requires it.

soxofaan’s picture

soxofaan commented

Good point.

but why are you using switch instead of a simple if?

olli’s picture

olli commented
StatusFileSize
new captcha-2021759-3.patch928 bytes

Thanks for the review. Here is a simple if.

Status: Needs review » Needs work

The last submitted patch, captcha-2021759-3.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review

#3: captcha-2021759-3.patch queued for re-testing.

soxofaan’s picture

soxofaan commented
Status: Needs review » Fixed

committed,
http://drupalcode.org/project/captcha.git/commitdiff/ad2d40c

thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.