Closed (fixed)
Project:
Fivestar
Version:
5.x-1.10
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Dec 2007 at 17:57 UTC
Updated:
8 Mar 2008 at 19:12 UTC
Jump to comment: Most recent file
I have enabled Fivestar for Story content and set the Star display style to "Display average vote value". On the Story page, on first load I get the "Average rating" correctly for that story. When i hover over the stars I am able to click and vote.
After i vote, the star display changes to reflect my vote/rating, but the label continues to show "Average". Is this okay behavior? I was expecting the actual Average rating to reload (after taking the new vote into account).
Have just started to try this module so not sure if this is the expected result. I am attaching two screenshots to show the settings and the resulting behavior on the story node.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | fivestar_dynamic_title.patch | 812 bytes | quicksketch |
| fivestar-average-not-showing.png | 4.98 KB | captcha | |
| fivestar-story-setting.png | 23.52 KB | captcha |
Comments
Comment #1
quicksketchThis is intended behavior. It's possible that we should change the title of the form element from "Average" to "Your vote" after clicking, but updating the stars with the new average isn't a place we want to visit. I feel that most users would be very confused that they just clicked a star, why did it jump back (or up) to the value it was before? Sticking the star value is the default behavior of YouTube, NetFlix, Amazon, and others. I think it's the standard convention.
Comment #2
captcha commentedThank you for the clarification.
Yes, it would be nice to have the title updated to reflect the user's vote, as the main issue was that the title was inconsistent with the rating value, and hence confusing.
In fact, along the same lines, there is the same confusion in another choice of settings which I wanted to mention earlier but didn't feel like flooding you with issues.
When "User's vote if available, average otherwise" is selected for "Star display style" and there is no user vote for a story, the title is "Average" and the stars reflect the average value, when the user votes, the star value reflects the user vote, but the title remains "Average".
If you could fix this, then the title and the star values are consistent else it's confusing, thanks.
Comment #3
quicksketchSince implementing the various display types, it seemed obvious that someone would notice this oddity.
I've update the latest 5.x CVS with a version that dynamically updates the title as you hover over stars and after you have cast/canceled a vote.
Comment #4
captcha commentedThank you for the excellent responsiveness.
Comment #5
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #6
captcha commentedI tried the latest dev version Feb 23, 2008 and the problem of the inconsistent title persists.
Could you please check.
Comment #7
quicksketchThanks, I think there was a change in Drupal core that changed the labels of fields from
to
This patch makes Fivestar update the titles properly in Drupal 5.5 and higher (including Drupal 6).
Comment #8
captcha commentedWorks, tested the Average star value option.
Thanks.
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.