variables not set?

Can't reproduce this on my test box. It's working fine.
Can anyone else?

Sounds like it might be related to: http://drupal.org/node/view/2015
(Both reported by anonymous, but the language used in each report is very similar, so I'm guessing it's the same person.)

This is caused by the fact Drupal generates incorrect HTML code for the "Configure 'who is online' block" page; form items with quotes are not handled properly (eg. look at the button's HTML code). Marking this critical.

I've come to the conclusion that the theme_blocks() function should wrap every block with div of class "block-module-delta":

$css_class = "block-$block->module";
if ($block->delta) {
  $css_class .= "-$block->delta";
}
print "<div class=\"$css_class\">";
theme("block", $block_data["subject"], $block_data["content"], $region);
print "</div>";

As there are lots and lots of cases where this sort of thing is useful, and it would enforce the naming convention nicely.

The bad HTML is being generated because of the embedded apostrophe in the call to form_submit():

statistics.module:form_submit("Submit \"who's online\" block changes");

calls common.inc:check_form() on this string,

calls common.inc:drupal_specialchars($text, 0)

calls htmlspecialchars() with ENT_NOQUOTES set, so the apostrophe does not get converted.

Calling drupal_specialchars() with ENT_QUOTES instead of zero makes this button's HTML generate correctly, but what does it break?

At a minimum, the call in check_form() of drupal_specialchars() should be changed to pass ENT_NOQUOTES intead of "0" since it is non-obvious that ENT_NOQUOTES has the value of 0.

--
Slavica

dries said this patch had been applied 2 or 3 days ago [1] - but it hasn't. please re-apply.

[1] http://drupal.org/node/view/2048#3316