We're seeing some issues with stickied action buttons in tabs, or when there are multiple sets of action buttons on a page. The width on the sticky element(s) is set to the width of the first sticky wrapper in the jQuery collection - not desired when there are multiple sticky elements on a page. Also, if a sticky element is invisible - e.g. in a tab - then its parent's height is set to 0.

This patch remedies these 2 issues.

CommentFileSizeAuthor
#2 sticky_edit_actions-tabbed_buttons_fix-2008224-2.patch1.4 KBbreathingrock
#1 sticky_edit_actions-tabbed_buttons_fix-2008224-1.patch3.6 KBbreathingrock
sticky_edit_actions-tabbed_buttons_fix.patch3.6 KBbreathingrock

Comments

breathingrock’s picture

breathingrock commented
StatusFileSize
new sticky_edit_actions-tabbed_buttons_fix-2008224-1.patch3.6 KB

Re-submitting patch file with issue #.

breathingrock’s picture

breathingrock commented
StatusFileSize
new sticky_edit_actions-tabbed_buttons_fix-2008224-2.patch1.4 KB

Modifying the core waypoints-sticky.js wasn't necessary. Here's another patch that only modifies sticky-edit-actions.js.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Active » Fixed

Thanks for this!

Committed with a19be29

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixing some language.