Problem/Motivation

This is not a critical issue but it was needed to complete a project.
Steps to reproduce:

Under checkout settings, configure the following:

  • In "General checkout settings", check "Enable anonymous checkout (users can checkout without logging in)."
  • In "Checkout completion settings", uncheck "Login users when new customer accounts are created at checkout."
  • In "Checkout completion settings", uncheck "Send new customers a separate e-mail with their account details."
  • In "Checkout completion settings", uncheck "New customer accounts will be set to active. Uncheck to create new accounts but make them blocked."

    Other settings values are not relevant.

    With this setup it's expected that new users created at checkout get the "pending approval" email for new users. Instead they are being sent the "no approval required" email, regardless of the choice made under Checkout completion settings.

    Proposed resolution

    The attached patch adds a condition in uc_cart.module to check for the selected checkout option and sends out the corresponding email.

    Remaining tasks

    Patch has been tested successfully.

    No UI or API changes have been made. Would be good to get some additional review.

    • CommentFileSizeAuthor
    #8 1983358-blocked-user-welcome-mail-D7.patch2.08 KBlongwave
    #6 1983358-blocked-user-welcome-mail.patch861 byteslongwave
    0001-Fix-for-blocked-new-user-email.patch1.51 KB5t4rdu5t

    Comments

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented
    Status: Patch (to be ported) » Needs review

    Status: Needs review » Needs work

    The last submitted patch, 0001-Fix-for-blocked-new-user-email.patch, failed testing.

    tr’s picture

    tr commented

    Isn't this essentially duplicate of #1258370: Ubercart's setting 'Login users when new customer accounts are created at checkout.' should respect core's "Require e-mail..." ?

    tr’s picture

    tr commented

    Double post...

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented

    Not quite; that was about logging in the user automatically, this is about sending a correctly worded user email if the new account is blocked by default.

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented
    Status: Needs work » Needs review
    StatusFileSize
    new 1983358-blocked-user-welcome-mail.patch861 bytes

    This patch is simpler and should avoid the test errors.

    @5t4rdu5t: Can you test this patch and confirm it works as expected?

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented
    Version: 6.x-2.x-dev » 7.x-3.x-dev
    Status: Needs review » Patch (to be ported)

    Committed #6, needs porting to 7.x.

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented
    Status: Patch (to be ported) » Needs review
    StatusFileSize
    new 1983358-blocked-user-welcome-mail-D7.patch2.08 KB

    Ported to D7, with test.

    longwave’s picture

    longwave
    he/him
    Primary language English
    Location UK
    commented
    Status: Needs review » Fixed

    Committed #8.

    Status: Fixed » Closed (fixed)

    Automatically closed -- issue fixed for 2 weeks with no activity.

    Anonymous’s picture

    (not verified) commented
    Issue summary: View changes

    Adding remaining task