Console error with Commons 3.1 [#1960716]

I tried adding Navbar to a site running Commons 3.1 and the latest nightly dev snapshot (April 1) of the Commons Origins theme.

Looks like we have a JS parse error, and in the console log I see,

Uncaught TypeError: Cannot read property 'eventhandlerViewportOffsetChange' of undefined jquery.js:35

Comment	File	Size	Author
#4	1960716.patch	305 bytes	jessebeach
#2	help-me-obi-wan-kenobi.jpg	22.61 KB	webchick

Comments

ezra-g commented 4 April 2013 at 00:08

I believe this is happening only on pages that use the Origins theme, but not the AT Admin theme.

she/they

English

Vancouver 🇨🇦

commented 4 April 2013 at 00:20

Assigned:	Unassigned	» jessebeach
Priority:	Normal	» Major

Status	File	Size
new	help-me-obi-wan-kenobi.jpg	22.61 KB

Help us, Jesse! You're our only hope!

(Stealing your image ;))

Cat saying help me obi wan

Sel_Space commented 4 April 2013 at 00:47

The problem comes from the dependency with the overlay module , once you enable the module the bug goes away
at the ligne 18 navbar.js

$(document)
            .bind('drupalViewportOffsetChange.navbar', $.proxy(Drupal.overlay, 'eventhandlerViewportOffsetChange'))
}

there is a call to Drupal.overlay function which will be undefined if the overlay module isn't enabled

jessebeach commented 4 April 2013 at 02:07

Status	File	Size
new	1960716.patch	305 bytes

So $.extend() doesn't create a property if it doesn't exist on an object already.

I needed to add this:

Drupal.overlay = Drupal.overlay || {};

jessebeach commented 4 April 2013 at 02:30

Status:

Active

» Closed (fixed)

Es funktioniert.