Core is inconsistent with the placement of "Save", "Preview", "Delete" and "Reset" placement. Ideally they should be consistently titled (occasionally with additional information, i.e. 'save settings' 'reset to defaults' etc.), and in a consistent order on the page. I often find my mouse hovering automatically over the wrong button before I read it and have to adjust, which isn't good.
In some forms, Preview comes before Save, Reset comes before save, or the other way 'round. Since most applications have the "OK" button to the left, I'd suggest this general rule for layout:
Save >> Preview >> Reset >> Delete
This would avoid the "Save" button ending up in the middle of the node form (the hardest place to target), and some other inconsistencies.
Attached is patch which deals only with the Node and Comment forms. I've renamed "Post comment" and "Preview comment" to "Save" and "Preview" which I'm splitting out of #37283. I'll have a look for other places, but could do with a general review on the standardisation before I go grepping.
Comment | File | Size | Author |
---|---|---|---|
#1 | buttons.patch | 3.08 KB | catch |
save_preview.patch | 3.02 KB | catch | |
Comments
Comment #1
catchI had a quick look through most of the forms in core, and I think node and comment may be the only culprits.
All site settings buttons are:
user/%/edit and profile forms are both
Here's a patch that actually works.
Comment #2
catchComment #3
blackdog CreditAttribution: blackdog commentedTested, and I'm so happy this is getting fixed! If there aren't any more forms to fix, this is RTBC.
Comment #4
catchWell I manually checked all the other forms in I could think of core, and they appear to be the right way 'round. So if you're happy with how this works, feel free to RTBC it. If there's a form left out, then it could always be done in another issue - my main concern is the node and comment forms anyway, since these are 'site visitor' facing.
Comment #5
blackdog CreditAttribution: blackdog commentedComment #6
Gábor HojtsyThanks, committed.
Comment #7
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.