Closed (fixed)
Project:
Eloqua API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2013 at 16:17 UTC
Updated:
23 May 2016 at 22:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
iamEAP commentedWe have some of this in our repo and just haven't contributed it back up. If I remember correctly, it was mostly lifted from that Eloqua module anyway.
Comment #2
dwightaspinwall commentedThat's cool, or if you don't have time for it, we'll probably be tackling it in the next few weeks and can submit a patch (to D6).
Comment #3
iamEAP commentedGreat! Either way.
Comment #4
iamEAP commentedLooks like we're tracking the actual tracking code addition here: #1984680: Add Eloqua tracking. Since that has more activity and a patch, I'll repurpose this for the latter half of initial post (using JS to append the Eloqua GUID to the form when re-posting), which could easily be done generically, I think.
Comment #5
iamEAP commentedCommited the attached patch to dev (see: edb7f82)
Setting to 6.x and marking patch to be ported, since 6.x users could easily benefit.
Comment #6
iamEAP commentedFor a D6 backport, note this commit as well: f28dcc1
Comment #7
aziznana786 commentedHas anyone managed to get this to work i.e. get the API to send over Eloqua GUID information while sending a form submission. I am trying to configure our new module and need some assistance in setting it up.
Any help would be much appreciated
Comment #8
iamEAP commented@aziznana786 Would you mind opening up a new issue of category "support request?" I'd be happy to answer any questions there.
Comment #9
drupalninja99 commented@iamEAP thank you for the work on this. I think that patch got lost in the whole D7 upgrade. I took the javascript we needed for the GUID detection and ported it back to the current D7 project (which has an eloqua_webform submodule). This looks like it's working now. When I test locally I see the GUID hidden field populated. I did not add the extra code for 'enabling' tracking bc I think most ppl will want it and it doesn't hurt anything.
Comment #10
albert volkman commentedOne last small tweak.
Comment #11
iamEAP commentedI'm a little confused; neither of these patches appear to be related to the Eloqua API module. GUID support already exists in Drupal 7 dev.
This issue is about backporting the D7 GUID work to D6.
Comment #12
iamEAP commentedComment #13
drupalninja99 commentedLooks good, I have committed
Comment #14
iamEAP commentedI think you guys are in the wrong issue. Moving back to the original status.
Comment #15
drupalninja99 commentedI think you mean backporting it to d6? I should mention that I don't think the fix actually ever made it to D7 (must have fallen through the cracks during the port). So now that its fixed in d7 we have to decide whether its worth porting backwards for the 19 sites that use this module. I would vote no.
Comment #16
iamEAP commentedThere was no port. This module was originally written in D7 and a D6 backport was generously contributed some time ago. GUID support for Eloqua API-enabled forms was committed to the 7.x branch here, with a minor followup here.
Comment #17
drupalninja99 commentedAh ok I know now why I was so thoroughly confused. We maintain the Eloqua module, but this is the 'Eloqua API' module. We should talk ab merging these modules at some point.
Comment #18
iamEAP commentedDefinitely.
Comment #19
iamEAP commentedClosing this out as 6.x is no longer supported and the fix is already in 7.x.