Perhaps a Javascript conflict? The toolbar shows up on pages, however the buttons do not. Mouseover shows correct action in tooltip, clicking performs correct function... Just no button icons.

Tried Safari and Firefox (no difference). Toolbar w/buttons works correctly on share42 site.

CommentFileSizeAuthor
#12 1.png24.69 KBvmkazakoff

Comments

duozersk’s picture

mholve,

Have you put the icons.png along with the share42.js file to the "sites/all/libraries/share42" folder?

Thanks
AndyB

mholve’s picture

Assigned: Unassigned » duozersk
Category: bug » support

Yes, the files exist:

# ls -l sites/all/libraries/share42/
total 12
-rw-r--r-- 1 apache nobody 7928 Jan 24 2013 icons.png
-rw-r--r-- 1 apache nobody 2101 Jan 24 2013 share42.js

duozersk’s picture

Then can you please right-click any button (not-visible now), select Inspect element and inspect the style attribute of the selected "a" HTML tag? There should be background property, like this one:
background:url(http://drupal7.local/sites/all/libraries/share42/icons.png) -64px 0 no-repeat

Or just copy the whole "a" tag and paste it here in the comment using the "code" wrapper.

Thanks
AndyB

franzkewd’s picture

I fixed the same problem OP has by disabling 'Aggregate JavaScript Files' (admin/config/development/performance).

Hope it helps.

Cheers.

duozersk’s picture

Category: support » bug

franzkewd,

Thanks for your comment - then this definitely a bug report; will fix it soon.

Thanks
AndyB

duozersk’s picture

Status: Active » Fixed

Fixed for both D6 and D7; wait for the 1.1 releases (several minutes usually) - it will work just fine with JS aggregation turned on.

Thanks
AndyB

Juan C’s picture

Version: 7.x-1.0 » 7.x-1.1
Component: User interface » Code
Assigned: duozersk » Unassigned
Status: Fixed » Active

I just tried the recent 7.x-1.1, got the following error message:

"Notice: Use of undefined constant BLOCK_CACHE_GLOBAL - assumed 'BLOCK_CACHE_GLOBAL' in share42_block_info() (line 29 of /var/www/vhosts/xxx/httpdocs/sites/all/modules/share42/share42.module)."

Thanks for this great module.

Cheers,

duozersk’s picture

Version: 7.x-1.1 » 7.x-1.0
Component: Code » User interface
Assigned: Unassigned » duozersk
Status: Active » Fixed

Juan C,

Thanks for a report. Please open a new issue for another issue next time (hope you understand what I'm trying to say here).

The notice you have reported was fixed in this commit - http://drupalcode.org/project/share42.git/commit/94c0dc4 - you can download a snapshot from there if you need the module code without this issue. I won't release another stable version just with this fix - want to wait for some time (usually 2 weeks) for more bug reports.
The hotfix release was just for original major issue affecting the functionality of the module.

I will change this issue properties as they were set previously.

Thanks
AndyB

mholve’s picture

Yep, 7.x-1.1 fixed it. Thanks! :)

hristos’s picture

I download 6x1.1 but the icons don't appearance again what' happens

duozersk’s picture

Vesela,

I don't really understand what you mean by "again" - please create a new issue for your problem (and explain in detail what you did and how you configured the module, and how exactly the icons are not shown), the one discussed here has been already fixed.

Thanks
AndyB

vmkazakoff’s picture

StatusFileSize
new24.69 KB

I found, that module do not work on local install of drupal. Here the code:

<a rel="nofollow" style="display:inline-block;vertical-align:bottom;width:32px;height:32px;margin:0 6px 6px 0;padding:0;outline:none;<strong>background:url(/sites/all/libraries/share42/icons.png)</strong> -0px 0 no-repeat" href="#" data-count="fb" onclick="window.open('http://www.facebook.com/sharer.php?s=100&amp;p[url]=http%3A%2F%2Flocalhost%2Felearn%2F&amp;p[title]=elearn&amp;p[summary]=&amp;p[images][0]=', '_blank', 'scrollbars=0, resizable=1, menubar=0, left=100, top=100, width=550, height=440, toolbar=0, status=0');return false" title="Поделиться в Facebook" target="_blank"></a>
duozersk’s picture

Vladimir,

Thanks for the report. I have created a new issue for your problem cause this one is fixed and your issue is completely different:
http://drupal.org/node/1909862

Please create separate issues for separate problems.

Thanks
AndyB

vmkazakoff’s picture

OK. Sorry, i supporse that it is the same :)

1biT’s picture

HI,

I installed the 7.x-1.1 today but unfortunately I have faced this problem. :-(
I have commented the line 29th in share42.module.

/** 'cache' => BLOCK_CACHE_GLOBAL, **/

Therefore the problem was solved...I hope.

Could you please explain what this line does?

Thanks & Regards,
1biT

duozersk’s picture

Status: Fixed » Closed (fixed)

Tibor,

This line had a mistake, corrected by this commit: http://drupalcode.org/project/share42.git/commit/94c0dc4
Basically, this commit changes BLOCK_CACHE_GLOBAL => DRUPAL_CACHE_GLOBAL (the difference in constant naming between Drupal 6 and 7).
I will make a new release soon that fixes it - for now you can use the dev version.

If you have any other concerns please open a new issue. This one is fixed and will stay as fixed, please do not post anything here.

Thanks
AndyB

dianacastillo’s picture

the latest version has that bug fixed 7.x-1.3, thanks