I have some views pages that have no menu item. Therefore the title in the menu router item is empty. As a consequence piwik tracks all of the pages without setting the title respectively sets it an empty string.

Sending patch after I got an issue number.

CommentFileSizeAuthor
#1 piwik-fix_dont_set_empty_page_titles-1863010-1.patch721 bytesmarcusx

Comments

marcusx’s picture

marcusx commented
Status: Active » Needs review
StatusFileSize
new piwik-fix_dont_set_empty_page_titles-1863010-1.patch721 bytes

Patch...

Remove empty item from menu system before using drupal_json_encode, also set title using drupal_set_title if there is no title in menu_router table.

hass’s picture

hass commented

Thanks for report. Why are we not changing function _piwik_get_hierarchy_titles() ? We should write tests.

hass’s picture

hass commented
Issue summary: View changes
Status: Needs review » Fixed 
+++ b/piwik.module
@@ -113,7 +113,11 @@ function piwik_page_alter(&$page) {
+      if ((count($titles) < 2) && !drupal_is_front_page()) {
+        $titles[] = drupal_get_title();
+      }

I do not understand the reason for this, but added the array_filter() as I was able to reproduce the bug with a view. The filtering of empty titles has fixed all issues for me.

hass’s picture

hass commented

http://drupalcode.org/project/piwik.git/commit/25f5751
http://drupalcode.org/project/piwik.git/commit/7e255d8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.