entity_bundle_plugin_rebuild_fields() does too many field updates on cache clear, it should be smarter and only update a field if it's really needed.

CommentFileSizeAuthor
#3 entity_bundle_plugin-performance-improvements-1794522-3.patch11.53 KBjsacksick
#2 entity_bundle_plugin-performance-improvements-1794522-2.patch9.53 KBjsacksick
#1 1794522-performance_improvements.patch9.54 KBamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 1794522-performance_improvements.patch9.54 KB

Here's a patch for that.

It also contains a test, some whitespace fixes and a partial rollback of the Entity API controller changes from http://drupalcode.org/project/entity_bundle_plugin.git/commit/ae8692b which weren't really needed.

jsacksick’s picture

jsacksick commented
StatusFileSize
new entity_bundle_plugin-performance-improvements-1794522-2.patch9.53 KB

This patch fails when applying from a .make, here's a new patch that tries to fix the issue.

jsacksick’s picture

jsacksick commented
StatusFileSize
new entity_bundle_plugin-performance-improvements-1794522-3.patch11.53 KB
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Committed!

Automatically closed -- issue fixed for 2 weeks with no activity.