Fixed some miscellaneous errors/warnings for drupal core coding standards.

Still a work in progress. Needs @file docs, some lines over 80 chars, and comments for function parameters/returns.

CommentFileSizeAuthor
drupal_to_drupal_data_migration-coding_standards.patch95.62 KBroberttstephens

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Postponed

As I'm working on a project involving migrating several D6 and D7 sites to a different D7 environment, migrate_d2d is undergoing some rapid changes - once we're through that, and I'm ready to promote it to a full project, will be the time for cleanup tasks like this.

I will note that I strongly believe that aligning chained methods with their opening is more readable than insisting on a two-character indentation. I.e.

    $query = Database::getConnection('default', $this->sourceConnection)
             ->select('files', 'f')
             ->fields('f')
             ->orderBy('timestamp');

is more maintainable than

    $query = Database::getConnection('default', $this->sourceConnection)
      ->select('files', 'f')
      ->fields('f')
      ->orderBy('timestamp');
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Version: » 7.x-2.x-dev
Status: Postponed » Fixed

I've run coder over migrate_d2d and fixed any applicable issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.