Closed (fixed)
Project:
Path Breadcrumbs
Version:
7.x-2.0-beta14
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Jun 2012 at 14:03 UTC
Updated:
25 Jun 2012 at 22:07 UTC
Jump to comment: Most recent file
Comments
Comment #1
spleshkaWow, interesting. Thanks, I will check this.
Comment #2
arrubiu commentedI'm also working on code, if I find something I'll wrote it :)
Comment #3
kalabroAfter deep research I can say the problem is that path_breadcrumbs actually doesn't support Ctools exportables.
We can add unique index to 'machine_name' field too.
ctools_export_crud_*functions.So, if we want to support Ctools exportables (including Features), we shout do a lot of work with current logic and UI. One more way is to use Ctools export_ui plugin (which “Views” and “Custom content panes” successfuly use) which takes half the work.
Need maintainer's opinion.
Comment #4
spleshkaOkey, I got your idea. We are really need to add primary key to machine name and replace all
dbactions withctools_export_crud. I hope that I will have some free time tonight to make all this changes.Thanks for the good module review, @kalabro. You are one of the most responsible Drupal developers I ever know, I like this :)
Comment #5
kalabroSo, here is big patch I have created to solve the problem.
Important notes:
path_breadcrumbs_update_7214().path_breadcrumbs_load_by_path()added to load variants by path.path_breadcrumbs_ui_breadcrumbs_list()because we need full objects to save weights.$path_breadcrumbsvariable instead of $path_breadcrumb and $breadcrumb.git mv path_breadcrumb.api.php path_breadcrumbs.api.phpis needed but not included in this patch.Particular attention was paid to exporting, importing and "feature"-ing.
Comment #6
spleshkaThanks, very cool!
I spend three hours for patch review. What I did:
Finally patch was commited at e4ccf6a and tagged as new 7.x-2.0-beta14 release.