effect the "Set public/published" feild in the submission form

Comments

ax’s picture

ax commented

this is fixed by removing

    if (!is_numeric($node->status)) {
      $node->status = 1;
    }

at line 909 in node.module.

are you sure you want this, eg. having new nodes unpublished? isn't what you want to have new nodes queued for moderation?

Roy’s picture

Roy commented

Yes, I want to queue for moderation but if I check "Moderate" and then publish, the node is queued and the "promote to front page" is disabled so in adition to swiching to "approved" - when approving, I have to remember always to enable the "promote to front page". If instead I disable "Set public/published" than the node is queued and the "promote to front page" remains enabled.

killes@www.drop.org’s picture

killes@www.drop.org commented
Category: bug » feature

Not really a bug, rather a feature.

ax’s picture

ax commented
Category: feature » bug

i think this /is/ a bug. and would suggest to remove the mentioned 3 lines. what are they for? could someone who knows please confirm?

killes@www.drop.org’s picture

killes@www.drop.org commented
Title: content settings > unchecking "publish" does not.. » Re: [drupal-devel] bug #1627 : content settings > unchecking "publish" does not..

On 22 May 2003, ax wrote:

> 22/05/2003 - 03:29 : ax
> i think this /is/ a bug. and would suggest to remove the mentioned 3
> lines. what are they for? could someone who knows please confirm?

Those lines make apparently sure that $node->status is not empty.
That is why I think it is not a bug. One could of course change it to 0.

Cheers,
Gerhard

al’s picture

al commented
Title: Re: [drupal-devel] bug #1627 : content settings > unchecking "publish" does not.. » "publish" checkbox in admin node settings doesn't work properly.
dries’s picture

dries commented
Title: "publish" checkbox in admin node settings doesn't work properly. » publish checkbox in admin node settings doesn't work properly
Assigned: Unassigned » dries

The fix was different from what Ax suggested though.

Anonymous’s picture

(not verified) commented