It isn't working.

I'm getting this error:
TypeError: 'null' is not an object (evaluating '$('#slidebox_trigger').offset().top')

line 14 slidebox.js

tried both the 1.x version and 2.x version, same error

CommentFileSizeAuthor
#8 slidebox-jquery_offset-1619956-8.patch1.59 KBAnonymous (not verified)
#6 slidebox-jquery_offset-1619956-6.patch585 bytesAnonymous (not verified)

Comments

Enes’s picture

Enes commented

Slidebox panels work well. Panels using the Node template. Why is this?

tchopshop’s picture

tchopshop commented

I don't understand your question. Does this have something to do with Panels?

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

Sorry for the delay in response - for some strange reason the block in the dashboard didn't show a new open issue. :/

So far, I have not been able to reproduce this issue myself. Can you please provide more details, such as the specific browser and version of that browser that you are using?

julien.reulos’s picture

julien.reulos commented

I can't understand what is happening on my website. Some nodes are showing the slidebox, some others are not... Worst, I have 2 identical nodes from the same content type, and the first one is showing the slidebox, the other one not.

Debug with Firebug for Chrome:
Uncaught TypeError: Cannot read property 'top' of null slidebox.js:14

And with Firebug for Firefox:

$("#slidebox_trigger").offset() is null
var distanceTop = $('#slidebox_trigger').offset().top - $(window).height();

Same with 7.x-2.x or 7.x-1.5.

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed (maintainer needs more info) » Active

Okay, so that means that for some reason .offset() is returning null in some cases. I'll have to look into it more as I haven't run into that issue.

I've got a couple of hard deadlines I'm trying to meet on some projects and a sister's wedding coming up, so I'm not exactly sure at the moment when I'll be able to spend some real time on this issue, but it's likely that it won't be until after the first of July.

Patches are welcome, by the way. :)

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new slidebox-jquery_offset-1619956-6.patch585 bytes

I'm still not sure what's causing the issue, as I can't reproduce it. I've even stepped through it with Firebug and Chrome Developer Tools to see what was actually going on during the loading, and I couldn't find a time where it would return null. However, this is with a clean install of Drupal.

I can try and offer this patch that wraps the heights in parseInt and let you see if that happens to fix it, but I'm really not sure at all about what is going on here.

tchopshop’s picture

tchopshop commented

I applied the patch to 1.x version... it still gives me the same error. Do you want a URL to see? Go to http://myspiltmilk.com/eastern-sea-thinks-big (for example).

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new slidebox-jquery_offset-1619956-8.patch1.59 KB

Okay. I think I see what's happening there. I'm still loading the Javascript even if the content type is disabled in Slidebox's configuration. So while the HTML for the slidebox is not being loaded on those pages whose content type is not enabled for Slidebox, the Javascript still is and is basically saying "hey, I can't find this div you told me about".

Here's a patch to try and let me know if it works in your case. It should no longer be trying to load the JS or CSS on any node where the node type is not selected in Slidebox configuration settings.

tchopshop’s picture

tchopshop commented

Brian, thanks, but the content type is enabled in the slide box configuration -- it has always been. I've set it to using the article content type in the example above. So even though I added the patch in #8, I'm still getting the error (in Safari's Web Developer tools).
Elena

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Active

It looks like you're using Display Suite based on some of the classes on wrappers, am I correct? I have not tested this with DS.

I understood when taking over this module that it didn't work with Panels at the time, and I'm sure that's probably the same reason it doesn't seem to work with DS and is something that I plan to address with #1372260: Let's make this more of an API.

tchopshop’s picture

tchopshop commented

Ahhh... that makes sense! I'll follow that issue then...

julien.reulos’s picture

julien.reulos commented

Brian, that's correct, I disabled Display Suite and Slidebox suddenly works ! Sorry I didn't see it myself before...

Anonymous’s picture

Anonymous (not verified) commented
Title: TypeError » Slidebox should only load its JavaScript and CSS on nodes where Slidebox is active
Status: Active » Fixed

Not a problem. Another issue was identified and fixed during the process, so its a net positive.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.