The new 2.x branch currently does not work properly with features... As an example: it still tries to call variable_realm_controller_build(), which has been removed and is currently causing a fatal error during features rebuild ("Call to undefined function ...").

CommentFileSizeAuthor
#14 1612484-features_export_notice-14.patch684 bytesjose reyero
#12 variable_realm_features_export_fix-1612484-12.patch702 bytesdasha_v
#4 features-fix-1612484-4.patch4.16 KBbforchhammer
#2 features-fix-1612484-2.patch1.29 KBbforchhammer

Comments

bforchhammer’s picture

bforchhammer commented
Assigned: Unassigned » bforchhammer

I'm on this one.

bforchhammer’s picture

bforchhammer commented
StatusFileSize
new features-fix-1612484-2.patch1.29 KB

Here's a patch. Fairly straighforward, so unless something comes up I'll probably commit this later today... :)

bforchhammer’s picture

bforchhammer commented
Assigned: bforchhammer » Unassigned
Status: Active » Needs review
bforchhammer’s picture

bforchhammer commented
StatusFileSize
new features-fix-1612484-4.patch4.16 KB

Hm, realms also need the "module" key in their info array, otherwise features can't add the right module dependencies.

jose reyero’s picture

jose reyero commented

Looks good to me. Just remove that 'dpm' :-)

bforchhammer’s picture

bforchhammer commented
Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xcafebabe’s picture

xcafebabe commented

Using Features 7.x-2.0-beta1+1-dev and Variable 7.x-2.1+7-dev, when I try to include Global: All Variables in my feature this error shows up:

Notice: Undefined index: module in variable_realm_features_export() on line 35 of /sites/all/modules/contrib/variable/variable_realm/variable_realm.features.inc

Some hint to try to help and fix this issue?

acrollet’s picture

acrollet commented

@xcafebabe: you need to re-export your feature after updating to -dev and the error should go away.

richsky’s picture

richsky commented
Version: 7.x-2.x-dev » 7.x-2.2
Status: Closed (fixed) » Active

Latest version (2.2) with this patch (#4) and still getting
Notice: Undefined index: module in variable_realm_features_export() (line 35 of E:\Web\Drupal_7\sites\all\modules\variable\variable_realm\variable_realm.features.inc).

artis.bajars’s picture

artis.bajars commented

I can confirm this still being an issue, using Features 2.0-rc1 and Variable 2.2. Feature dependencies are not added correctly because of this.

dasha_v’s picture

dasha_v commented
StatusFileSize
new variable_realm_features_export_fix-1612484-12.patch702 bytes

The fix from #6 was lost in #1664154: Fix variable hooks invoked during bootstrap (Variable realm breaks pathauto).
Draft for the patch attached.

candelas’s picture

candelas commented

same problem, same versions.
thanks for any help :)

jose reyero’s picture

jose reyero commented
Status: Active » Needs review
StatusFileSize
new 1612484-features_export_notice-14.patch684 bytes

Ok, so it seems we need to add the 'module' value to the realm info.

The idea looks good, but the patch has too many checks and may change the results because it does a full replacement of $result[$key] instead of merging.

Let's try this one.

frazras’s picture

frazras commented

OK #14 seemed to have worked for me, well at least its no showin up in the logs nor is it preventing the feature from adding other entries anymore.

jose reyero’s picture

jose reyero commented
Status: Needs review » Fixed

Great, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.