Update jQuery Form Plugin to the latest in the git repository

I just ran into an issue (#1669960: Clientside Validation 1.33 fails on IE) with clientside_validation on D7, to support some functionality we added new 'methods' to javascript Array (Array.prototype.indexOf, Array.prototype.lastIndexOf) for IE < 9

The problem is that the current jquery.form.js version cannot handle this and IE < 9 users are getting a cryptic error message, so we need to backport this to Drupal 7 as well, pretty please.

JS crashes before sending anything for me on FF.

@nod_ care to share some more info: page, browser version, ...

Can you test on http://testswarmcv.h001.attiks.com/node/add/article it contains an override of jquery.form.js and works in FF13

Yeah sorry, Tested your link:

works on Opera 12

on FF 13.0.1 (linux) I get after clicking on the upload button:

An error occurred while attempting to process /file/ajax/field_image/und/0/form-k5equgFLOuhEMmZMnW5SVZIn6hRxiYaXoC5uFMXrSNk: Component returned failure code: 0x80460001 (NS_ERROR_CANNOT_CONVERT_DATA) [nsIDOMFormData.append]

Don't really have time to dig into it ATM. Can test/review though :)

@nod_ known problem, see #1575060: ajax_html_ids are broken for forms with file element (encoding=multipart/form-data)

Possible fix in jquery.form.js, fixing FF problem but untested:

                    if (typeof options.extraData[p] !== 'object') // <-- added, fails on html_ids[]
                        formdata.append(p, options.extraData[p]);

FYI: there's already a PR: https://github.com/malsup/form/pull/201/files

FYI: I committed the fix to clientside_validation on it's working in FF, see http://drupalcode.org/project/clientside_validation.git/commit/481c9e6 and http://testswarmcv.h001.attiks.com/node/add/article

Nice :) thanks for the follow up upstream.

#7 got committed upstream and is included in the latest version at http://malsup.github.com/jquery.form.js

Patch needs to be rerolled

That works, thanks :)

Can someone give details on what they manually tested with this patch?

Tested:

• uploading an image in node/add/article
• 'add more' button
• quickedit
• Views UI
• ajax exposed filter on a view (that would have worked if it wasn't telling me that the ajax callback URL /views/ajax is 404)

and that's pretty much everywhere the library is used.

Awesome, thanks!

Committed and pushed to 8.x.

Marking for backport to D7, but that'd be David's call.

Patch is in D8, untagging.

Right, isn't that what https://drupal.org/project/jquery_update is for?

To update this in core, we would basically need to pore over the release notes and also do a line-by-line code review to make sure there are no API changes. Because we don't really know how contrib modules are using the library. I am not volunteering for that line-by-line review :)

Also, http://malsup.com/jquery/form/#faq suggests that the latest version isn't even compatible with the version of jQuery that ships with Drupal 7 core...

Okay so in 7.x we're leaving this to contrib.

Postponing because this issue isn't blocking anything so to avoid wasting time we can just grab and test the latest version nearer to release.

3.50 now.

Tested things from #19, everything still works.

No longer applies.

Updating patch with reroll. Please review.

Committed/pushed to 8.x, thanks!