Closed (fixed)
Project:
Bean (for Drupal 7)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
3 May 2012 at 21:24 UTC
Updated:
17 Jun 2012 at 18:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
recidive commentedHere's a first crack at implementing this. Still needs to be tested. And needs a review on permissions implementation.
Comment #2
recidive commentedAnother patch, improving service methods help and parameters descriptions. Making them translatable. And changing permission for accessing the 'index' method to 'administer beans'.
Comment #3
indytechcook commentedThis is awesome stuff. Since I've never used services I can't comment on if it works (but I know it does after talking to dave) but I'd still like someone else to review. Most of the stuff is great. Just a few small comments.
It helps you add the object reference itself to the @param @param $bean Bean
This helps IDE's also do some fancy autocomplete and doxygen to do some awesome linkage.
Do we need both $bid and $bean passed in? You can get the bid from $bean->identifier()
Use bean_reset() instead of cache_clear_all()
Comment #4
skwashd commentedUpdated version of the patch.
Changelog
* Move functionality into bean.module as there is little point in a sub module given this doesn't add any hard dependencies and it is only enabled if the user enables the specific resources in services
* Deal with the issues noted above
* Improve access controls
* Update to use new "view bean page" permission
* Rerolled so it applies cleanly against current 7.x-1.x HEAD
* Various bug fixes
The Bean argument is needed for bean_services_update as the REST call PUTs to the specific bean id - such as http://example.com/api/bean/123.json
Comment #5
indytechcook commentedLooks good.
Comment #6
indytechcook commentedhttp://drupal.org/commitlog/commit/22232/93d5c0c60faaef1a8301553be1c2160...