Closed (fixed)
Project:
Secure Pages Hijack Prevention
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2012 at 18:34 UTC
Updated:
3 Dec 2013 at 22:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joe-b commentedThe problem I suspect is that you're using 6.x-2.x-dev version of Secure Pages, which no longer contains the securepages_url() function.
Instead you'd want rewrite the tail end of securepages_prevent_hijack_form_alter() to look something like this …
Diff attached.
With Secure Pages 6.x-2.x-dev I found a gotcha with Locale and path prefixes in URLs dropping double language prefixes into paths, in which case something like http://drupal.org/node/420386#comment-3587618 works, though I tidied up that code for use here into …
That's a bit fugly, really, and I'm pretty sure there's a better way of cleaning locale paths of language prefixes - just can't put my finger on any good example code to work from at the moment.
Comment #2
izmeez commentedThere appear to be several issues regarding securepages_prevent_hijack-6.x-1.x incompatibility with securepages-6.x-2.x but this issue seems to be the the key towards solving it.
Maybe #2129783: Not working with Secure pages 6.x-2.0 should be marked as duplicate and link to this issue.
Also #2129779: Secure Pages Prevent Hijack failed to set secure cookie which seems to also relate to another issue which is now fixed could be closed or also marked as a duplicate and link to this issue.
And #2132363: user page is white after secure pages 6.x-2.0 update could be marked as a duplicate and link to this issue.
This might help to cleanup the issue queue.
Comment #3
psynaptic commented@joe-b: I think your patch deals with this in the correct way. There are some extra blank lines and "secure" option is now redundant (that was a feature of the old securepages_url() function). I have attached a patch to resolve these (very minor) issues. Please create a separate issue to deal with the language negotiation URLs.
@izmeez: Thanks for listing those out. I have closed 2 issues that are exact duplicates of this and linked them here. I see the cookie problem as a separate issue to the undefined function and will close the duplicate cookie-related ones.
Comment #4
grendzy commentedThanks! This has been committed to a new 6.x-2.x branch, which should be published momentarily.