What's the situation with a D7 version of this? I can't see one so far - but what with the name change I may have missed it
Do you have it planned any time soon? Is it unecessary? Is there a work around?
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | fbssts-D7-port-1497884-7.patch | 9.67 KB | mathankumarc |
| #2 | fbssts-D7-port-1497884-2.patch | 9.48 KB | mathankumarc |
Comments
Comment #1
icecreamyou commentedI haven't put any thought or effort into planning or building a D7 version of this module yet.
Comment #2
mathankumarc commentedHere is the initial(Maybe complete) port.
Comment #3
icecreamyou commentedWell that was fast.
This patch doesn't upgrade everything: hook_perm() is now hook_permission(), hook_theme() has changed, and there's no migration path for the two settings variables. But it's a pretty good start -- thanks. @mathankumarc, I've given you full maintainer permissions on this project so you can commit and tag a new release if you'd like once these issues and the ones below are fixed.
The
index.php?q=part is required (otherwise this fails for sites with Clean URLs disabled).This function is already in statuses.js and as far as I can tell there's no reason for it to be added again here.
Put the ->condition() on a separate line so it matches the second one below it
Only one % sign is necessary (in D6 two are required because the first one is the escape symbol).
Use REQUEST_TIME instead of time()
Only one % necessary
Comment #4
mathankumarc commentedWill revise the patch and work with you on the D7 release.
Comment #5
mathankumarc commentedIn statuses.js file fbss_print_remaining() function was put in the following context,
So its not available outside of the statuses.js
How can we address this scenario?
Comment #6
icecreamyou commentedOoh, right. We can just move the function outside of that closure in statuses.js and replace $() with jQuery() inside of it.
Comment #7
mathankumarc commentedHere is the revised patch.
Added migration path also(However I'm not sure about that).
Holding on this until #1505346: Move fbss_print_remaining() out of jQuery closure gets fixed.
Comment #8
icecreamyou commentedI don't know what I was thinking about the migration path. Looking at it now I don't think a migration path is needed. The only reason variables would need to be migrated is if there is a name change, and there isn't one here. Sorry about that. Other than that this is RTBC
Comment #9
mathankumarc commentedAdded new branch for D7. Downloadable file will be available in another 12 hours.