I have a question about this module...
I choose to show my splashscreen in a colorbox but when I
try to add images in this colorbox with the html code for images no image is shown?
If I try to add text... that works
I choose in the settings full html.
What should be the problem?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | splashify-markup-1480264-7.patch | 868 bytes | cwithout |
Comments
Comment #1
chrisroane commentedThe image most likely can't be found. I would suggest using absolute links for any images you include. For example, if it is in a theme directory, I would use something like this:
<img src="/sites/default/themes/images/testing.jpg" />Comment #2
KaB0o commentedNo, I'm sure the image can be found because when I try an URL link (to an image) for example:
<a href="url">Link text</a>then the link occures and I can click and see the image.
Comment #3
chrisroane commentedThan it probably has to do with the format selection you are using. This module doesn't modify the code used in that field and my guess is that the format you are using doesn't allow images.
Comment #4
KaB0o commentedYou mean full html of filtered html?
Or am I wrong?
And how do I change my format then?
I thought Splashify was made to show images or content before people enter the website...
Comment #5
chrisroane commentedUnder the What tab, if you have one of the "Display entered text..." options selected, the field below that becomes a text format field. You can enter text/html there and select a format. Depending on the format that is selected there will determine how drupal handles that value. You can change the value by selecting a new format value under that drop down.
This module does not prevent any specific type of data from being displayed or used in a splash page. It is the same type of format field used under the body field for nodes.
If there is a problem here, I need to know the exact steps to follow to replicate the problem.
Comment #6
chrisroane commentedComment #7
cwithout commentedI have the same problem as kAB0o.
No matter what input format I selected, the output rendered with all the HTML stripped. Even with full HTML set not to limit allowed HTML tags, the HTML was stripped. I've found generally this happens when a module is using something besides check_markup() prior to output, which is what I found in splashify.display.inc.
The module is using filter_xss() instead of check_markup() to output the content. filter_xss() by default strips out all tags except 'a', 'em', 'strong', 'cite', 'blockquote', 'code', 'ul', 'ol', 'li', 'dl', 'dt', 'dd'. So it doesn't matter what input format is selected, all other tags are stripped. check_markup() returns content with all the filters of the selected input format applied.
Patch attached.
Comment #8
chrisroane commentedI still cannot replicate the stripping of image tags with how it was.
But I do think what you suggest is the correct way of doing this. So I updated the code and pushed it to the 7.x-1.x dev branch. I also pushed a new tag for 7.x-1.0-alpha2 today....which should hopefully show up later today.
Comment #9
venutip commentedHmm, not seeing an alpha2 release. Was it postponed?
Comment #10
chrisroane commentedvenutip:
At one point I tried to push it out as an alpha2 release, but I guess it didn't stick. I've been pretty busy during the last month, but I'll try to look at this within the next two weeks or so and get this pushed.
Comment #11
venutip commentedCool, I'll look for it. In the meantime, easy enough to patch.
Thanks!
Comment #12
chrisroane commentedI pushed the alpha2 release. It can be seen on the release page here: http://drupal.org/node/1423456/release .
I can't make this available ont he main page of the project until tomorrow.