Closed (fixed)
Project:
Simple Karma
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 May 2007 at 10:09 UTC
Updated:
30 May 2007 at 13:58 UTC
You should set the default value for 'simple_karma_bury_threshold' to a numeric value. This variable is used in the SQL in the buried_comments function. If the variable is not set or is set to an empty string by default (as is the case now), the queries in the buried_comments function will fail - at least in my version of MySQL.
You use the value of this variable in a less-than WHERE clause in your SQL.
Comments
Comment #1
mercmobily commentedHi,
Thank you for the bug report!
Actually, the problem isn't quite in the default...
If that variable is '', it means that comments will not get buried. The code will therefore NOT bury comments at all - and as a consequence, the functionality "See buried comments" is not meaningful anymore.
I took away the option to see buried comments if simple_karma_bury_threshold is set to '' (burying is disabled).
Can you test it in HEAD? Or shall I make a new release so that you can test it?
Also, how are you finding the module? I released it, but I have no idea who is using it. Since I fix bugs pretty much on the spot, my module ends up looking dead...
Bye,
Merc.
Comment #2
mercmobily commentedHi,
I did more testing, it really seems to work. So, the issue is closed and the new release will be available in about 2 minutes.
Merc.