As per #1386816: Rearrange and combine styles into .base.css, .admin.css. and .theme.css stylesheets (a.k.a. BAT) all commerce stylesheets we replace in hook_css_alter() got renamed and or combined since this commit: Issue #1386816 by googletorp: rearrange and combine stylesheets for each module into .base.css, .admin.css, and .theme.css stylesheets for an improved theme experience, causing the themed changes to be ignored.

CommentFileSizeAuthor
#1 at-commerce-Commerce_CSS_BATting-1443242-1.patch28.77 KBnickl

Comments

nickl’s picture

nickl commented
Status: Active » Needs review
StatusFileSize
new at-commerce-Commerce_CSS_BATting-1443242-1.patch28.77 KB

Synced all stylesheets as per the changes in the mentioned commit on commerce and found some css files that we were not overwriting, added those to the patch for completeness.

Tested on the commerce kick start install profile and can confirm that all commerce styles are being replaced now and nothing looked obviously out of place.
Probably will require a fine tooth comb and more testing.

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: Unassigned » Jeff Burnz
Status: Needs review » Active

OK, shit bugger, I am very busy this weekend, I will try to get to it - BAT is good, I like it, will get this done ASAP.

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: Jeff Burnz » Unassigned
Status: Active » Needs review

Sorry, x-post, awesome, I will test today/soon

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs review » Fixed

I applied the patch and pushed it up to DEV, but I may not have time to test it properly, I'll leave a note on the project page in the mean time, hopefully I get some more time today.

Gonna mark this as fixed, but we can reopen in case there is a problem.

nickl’s picture

nickl commented
Status: Fixed » Needs review

I was also unable to test it properly, still coming to grips with dCommerce.

I gather your idea is to get all the stylesheets of the contrib modules for commerce in there eventually?

If anyone has a commerce installation please change your theme and bring in the fine tooth comb, we need to have this looked at.

lets keep it at needs review, keeps it urgent. Patch committed to head, please review.

Jeff Burnz’s picture

Jeff Burnz commented

Yeah, I didn't really have time to test it out, the code looks fine and should be doing the job. I blew up my Kickstart install a few days ago with a dodgy install of some entity module, so I need to reinstall and get this up and running.

Not sure about the other modules, maybe the most obvious ones, but I gather there will be a lot of Commerce addons coming over the next few years, the idea was really a test because Commerce loads so much style and I was getting annoyed at overriding it all, this was a way of nuking it all and putting full control in the hands of the themer.

Jeff Burnz’s picture

Jeff Burnz commented
Issue summary: View changes
Status: Needs review » Closed (outdated)