Closed (fixed)
Project:
Features
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Feb 2012 at 08:51 UTC
Updated:
16 Oct 2013 at 17:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
joelcollinsdc commentedComment #2
joelcollinsdc commentedComment #3
roderikYes indeed.
I notice some consistency issues, though:
So I changed a header too. (Since the code outside features.drush.inc usually uses '$component' as a "Component type", I didn't change variables.)
Oh yeah, and I moved the processing of the argument more to the top (splitting one patch hunk into two) on purpose, because I need $filter_ctypes for my next patch :)
Comment #4
roderik...and if someone likes this, they might also like #2052579: Speed up features diff for selected components..
(That issue is 'needs work' because that patch fails to apply until this issue is incorporated.)
Comment #5
mpotter commentedI think "ctypes" needs to be changed to something like "components" to make it more consistent with other drush command arguments/options?
Comment #6
roderikI think not.
What drush commands refer to "components" are the individual items. Like 'views_view.VIEW_NAME'.
Our diff command cannot do this, but can only select the 'groups' of these components. Like 'views_view'.
IMHO if we refer to our selections as "components", we create confusion, by naming 2 different things "components". This is explicitly why I didn't name things "components", but chose 'ctypes' instead. 'component-types' would also do, if you like that long a commandline argument...
Comment #7
roderikReroll against RC3.
Comment #8
mpotter commentedCommitted to ac15c4e.