Upon upgrading to rc4 I started to notice that on mouseover, any <li> was getting a class of "expanded" which was screwing things up due to that class being used for other things in my css. I think it's related to this code:

activeItem && activeItem.trailEnd(commonParentDepth).removeClass('expanded');
mouseItem && mouseItem.trailEnd(commonParentDepth).addClass('expanded');
CommentFileSizeAuthor
#3 dqx_adminmenu.1418882-3.expanded-class-outside-of-menu-tree.6-x-3-x.patch6.82 KBdonquixote

Comments

donquixote’s picture

donquixote commented

Ok, so I should use a class other than "expanded". Such as, dqx_adminmenu-expanded.
I hate this :(

donquixote’s picture

donquixote commented

Ah, wait.. you mean, that the expanded class is added to li elements outside of the menu.. ouch!
This is serious.

donquixote’s picture

donquixote commented
StatusFileSize
new dqx_adminmenu.1418882-3.expanded-class-outside-of-menu-tree.6-x-3-x.patch6.82 KB

Attached patch should solve the problem (along with a bit of refactoring).
I am going to commit it to the dev branch. If you don't want to wait for the packaging script, you can pull from git instead, or deploy the patch.

donquixote’s picture

donquixote commented

I will publish this as rc5, as soon as I get some feedback.

donquixote’s picture

donquixote commented

I release it whatsoever.

donquixote’s picture

donquixote commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

minor edits