Player not displaying and throwing an error with Brightcove Field [#1341548]

When I try to display a video, I get the following error message:

Notice: Undefined variable: value in brightcove_field_get_value() (line 1649 of /Users/thomas/Sites/gilt/cms_about/docroot/sites/all/modules/contrib/brightcove/brightcove_field/brightcove_field.module).
Notice: Trying to get property of non-object in theme_brightcove_field_embed() (line 114 of /Users/thomas/Sites/gilt/cms_about/docroot/sites/all/modules/contrib/brightcove/brightcove_field/theme.inc).
Notice: Trying to get property of non-object in theme_brightcove_field_embed() (line 118 of /Users/thomas/Sites/gilt/cms_about/docroot/sites/all/modules/contrib/brightcove/brightcove_field/theme.inc).

Digging into the code, I can see that the brightcove_field_get_value() function looks pretty half-baked. In fact, I can't even gather what the function was supposed to accomplish:

function brightcove_field_get_value($instance, $stored) {
  if ($stored) {
    return $stored;
  }

  if (!empty($instance['settings'][$value])) {
    $instance['settings'][$value];
  }

  return NULL;
}

Without this function, players won't load and therefore render. Any idea what this function was originally supposed to do?

Comments

Comment #1

chromix commented 14 November 2011 at 22:12

When I change the brightcove_field_get_value() function like this, everything magically works:

function brightcove_field_get_value($instance, $stored) {
  if ($stored) {
    return $stored;
  }

  if (!empty($instance['settings']['brightcove_player'])) {
    return $instance['settings']['brightcove_player'];
  }

  return NULL;
}

Hopefully someone can commit a fix to this soon?

Comment #2

tamasd commented 16 November 2011 at 11:05

Status:

Active

» Fixed

Fixed in bc9776c67057697bd9886f3eabcbaf1482b74b2a. Thanks for the solution. This function was refactored recently, and I incidentally forget to properly rewrite it. A new release will be out in a few minutes.