The D7 version is not adding taxonomy terms to nodes.

Thanks to micahwalter for reporting this issue.

Comments

now100handed’s picture

now100handed commented

Subscribing

gclicon’s picture

gclicon commented
Status: Active » Closed (fixed)

I have committed an update for importing tags in Drupal 7. The update will be in the beta2 version that I will be releasing.

dakotaryan’s picture

dakotaryan commented
Version: 7.x-1.x-dev » 7.x-1.0-beta2
Priority: Normal » Minor
Status: Closed (fixed) » Active

Thanks for this great module!

I'm finding that tags do not import from Flickr (even using 7x-1-b2) unless you specify a list of tags to import on the user's account page.

I'm not sure this is the desired behavior. In my view, when the user account page tags field is left blank, this module should import ALL photos from flickr and add ALL the flickr tags to those nodes (creating new tags in drupal, if needed). If the user account page tags field contains something, this module should check each photo, determine whether it contains one of the tags specified, and only import it if it does.

In other words, I think the user account page tags field and the tags that are ultimately associated with the imported image nodes should be two separate things. Currently, the module is treating them the same way because tags are not added to a node unless the same tag is listed on the user account page. If there's an argument to be made for this being the correct behavior, I would say that maybe it should not be the default.

In my case, I was able to circumvent this issue by changing line 470 in /sites/all/modules/flickrsync/flickrsync.module from
$vid = variable_get('flickrsync_vocab', '');
to
$vid = variable_get('flickrsync_vocab', '1');

This works for me because '1' is the VID of the only vocabulary I'm using, but in general I think this behavior is suboptimal. flickrsync_node_save() should be reworked to correct this behavior.

Thanks,
Dakota

gclicon’s picture

gclicon commented
Assigned: Unassigned » gclicon

Hi Dakota,

Thanks for the note, the commit to the beta2 version was importing tags. It imports all tags if you have none listed in the setting on the user's account page and if you do have tags listed there, it only imports those tags. I will review the code and do some further testing to make sure this is still the case.

gclicon’s picture

gclicon commented
Status: Active » Fixed

I have tested and found that tags do import correctly.

changing 

 $vid = variable_get('flickrsync_vocab', '');

to 

 $vid = variable_get('flickrsync_vocab', '1');

would not really help since its possible to delete the vocab assigned to VID #1. If you've selected a vocab in the settings for flickrsync, this shouldn't be an issue.

I did commit a patch to make the user setting easier to understand. I renamed the "Flickr tags to import" field to "Only import Flickr photos with these tags". This should make that field a bit more easier to understand. It was a bit misleading (as you can tell from my previous comment, even I wasn't sure what that field did since I inherited this module).

I also fixed a check for the existence of the $vocab_term variable which was throwing errors on import of tags.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.