This module is used by drupal.org, and as part of the https://drupal.org/community-initiatives/drupalorg/drupal7 D7 Upgrade Initiative, we need to get it to a stable 1.0 release prior to launch.
What will it take to get a release of this module out the door before July 15th, 2012 so we can test it in-place during the QA phase? Let's use this issue to investigate and generate a bullet-point list of things that need to happen (or a list of links to other issues).
This module is fully upgraded to D7, and is in need of testing and QA so that a stable release can be created.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | port.10.patch | 7.51 KB | sun |
| #9 | 0001-issue-1306586-Port-Local-image-input-filter-to-Drupa.patch | 14.23 KB | grendzy |
| #6 | 0001-issue-1306586-Port-Local-image-input-filter-to-Drupa.patch | 13 KB | grendzy |
Comments
Comment #1
sunThat should be easy. Just replace the hook_filter() implementation, and remove the backported D7 code for DOM loading/serialization.
Comment #3
webchickTagging.
Comment #4
webchickFixing title.
Comment #5
grendzy commentedComment #6
grendzy commentedComment #7
sunoh, oy, sorry - how much different is this patch compared to #1344078: Local image input filter in core ?
Comment #8
grendzy commentedThanks for the link, though I'm not sure I understand the question. Does the D8 proposal affect the D7 port in some way?
Skimming quickly, the changes in #6 looks similar to #1344078: Local image input filter in core. The port from 6.x-1.x is intended for the Drupal.org D7 upgrade.
Comment #9
grendzy commentedHere's the same patch, plus an update function.
Comment #10
sunThanks! Had to rewrite the commit message. Also committed attached follow-up patch to bring the code in line with #1344078: Local image input filter in core and ran tests locally.
Will create a dev snapshot now.
Comment #11
sunThe dev snapshot is published now.
Can you guys let me know whether the D7 port and upgrade path fully works as intended, so we can create a stable release?
Comment #13
sunRe-opening, since #1648000: Local Image Input Filter needs a 1.0 release as part of the Drupal.org D7 Upgrade Initiative was created as duplicate.
Need to know whether testing on qa.d.o confirms that the ported code works as intended in order to create a stable release.
(Yes, there are automated tests, but they are very basic and mostly focus on security only.)
Comment #14
drummThis seems to be working okay at http://drumm-drupal_7.redesign.devdrupal.org/documentation/modules/block.
This module uses
$_SERVER['HTTP_HOST'], which isn't'drupal.org'for my dev site. Any images with absolute paths are considered non-local. Using my giant domain name in an absolute path does work as expected.Comment #15
sunThanks for confirming!
Created the stable 1.0 release.
Comment #16.0
(not verified) commentedUpdating the issue summary to reflect the need for testing and QA.