base.css is used in many themes. For example, rubik admin theme. So when I tried it out, it didn't work except with Garland. I believe this should use a more compliant naming structure to avoid this conflict. For example, base should be taskbar_base, taskbar_top, etc. Here's patch for at least the base theme.

Cool looking module / structure. Looking forward to hacking on it as I start adding more node.js to my site.

CommentFileSizeAuthor
taskbar_base.zip2.55 KBmarkwk
rename-base-css-to-taskbar-base.patch3.59 KBmarkwk

Comments

thehong’s picture

thehong commented
Status: Active » Postponed (maintainer needs more info)

I don't understand why you have conflict. The base.css can be loaded if it's there. Did you check file permission?

markwk’s picture

markwk commented

I enabled module on my site, set permissions and set different styles but none displayed correctly with my themes (corolla and rubik for admin). It only worked when I enabled Garland. The above patched changes made it work.

Are you not having the same issue with rubik, for example?

markwk’s picture

markwk commented

Here's an easier way to see the changes I made: https://github.com/markwk/taskbar/commit/136be736f5803841a76ff7e370769c2...

Nothing major, but fixed issue of me, at least.

jcisio’s picture

jcisio commented
Status: Postponed (maintainer needs more info) » Needs work

Ok, in Drupal, when there are multiple CSS files having the same name, only the last one is added. This allows subtheme overriding.

However, it looks like your patch only removes the base/ folder but does not rename it to taskbar_base ;)

thehong’s picture

thehong commented

There's no problem to rename the css file. But I dont believe the overriding @jcisio said on #4. I enabled rubik:

#1 http://minus.com/miApz7sUp#1 all base.css file loaded.
#2 http://minus.com/miApz7sUp#2 taskbar's base.css working
#3 http://minus.com/miApz7sUp#3 tao's base.css working.

jcisio’s picture

jcisio commented

In the Drupal API for drupal_get_css:

Themes may replace module-defined CSS files by adding a stylesheet with the same filename. For example, themes/garland/system-menus.css would replace modules/system/system-menus.css. This allows themes to override complete CSS files, rather than specific selectors, when necessary.

In #5 all three base.css are for 3 different targets (all, screen and print) so they are not overriden ;-)

markwk’s picture

markwk commented

Yeah, not sure about what happened on my setup. Not really sure the why, just that changing those variable and css names fixed it.

Also not sure how to patch such that it changes directory names ;) so I included the zip file.

linuxrevolution’s picture

linuxrevolution commented

I have to confirm that also with the amlekula theme the taskbar module is not working..... And we have no time to look further to fix it.... I hope you guys do something for it....

jcisio’s picture

jcisio commented
Assigned: Unassigned » jcisio

Ok let assign this to me. It's an easy fix, I'll do it later today.

linuxrevolution’s picture

linuxrevolution commented

Thanks a lot my friend! We have so much work at linux-revolution.gr and we really want the taskbar module to work also for our site! We 'll wait!

markwk’s picture

markwk commented

Shouldn't be hard this issue. Just change the base / bottom / default / top to taskbar_base, etc.

linuxrevolution’s picture

linuxrevolution commented

It's an issue that it must be fixed and for the others :) And i have no idea programming etc :)

jcisio’s picture

jcisio commented
Title: Base.css is used in many themes, creates conflict » Prefix shipped styles with taskbar_ to avoid conflict
Version: 6.x-1.0-beta5 » 6.x-1.x-dev
Status: Needs work » Fixed

Fixed in http://drupalcode.org/project/taskbar.git/commit/33a3c94

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.