Email notifications is horribly broken.
You can get a notification when a person sends you a friend request. But as a user you can't change the setting to not receive this. Also, there is code to notify you when friendship is approved, but that doesn't work.

CommentFileSizeAuthor
#5 1279370.5.emailNotifications.patch5.11 KBsocketwench
#1 flag_friend-1279370.patch5.07 KBmoonray

Comments

moonray’s picture

moonray commented
Status: Active » Needs review
StatusFileSize
new flag_friend-1279370.patch5.07 KB

And here's a patch for that. It adds a settings for on the user's account edit page, and makes all notifications work as expected.

quotesbro’s picture

quotesbro commented

Similar to #1122074: Friend notification works even if user disabled this option

mikl’s picture

mikl
Location Møn
commented
Status: Needs review » Needs work

FoodPop Mail-related settings

Missing a bit of cleanup there, eh?

Otherwise, it looks fine :)

harrrrrrr’s picture

harrrrrrr commented

tested and works

socketwench’s picture

socketwench commented
Status: Needs work » Needs review
StatusFileSize
new 1279370.5.emailNotifications.patch5.11 KB

Ugh. So I already committed a partial solution to this while bumbling around in the code: http://drupal.org/node/1975314

The above patch is actually a better solution than the one I came up with, so....reroll!

socketwench’s picture

socketwench commented
Status: Needs review » Fixed

Since there's been no motion on this, and it works for me, I've committed it to DEV.

http://drupalcode.org/project/flag_friend.git/commit/696ddb574c8d1167b46...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.