Need to test the plugin and publish it after it passes.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | support_for_drupal_7-1273132-5.patch | 11.34 KB | hamax |
| #5 | svn diff for latest modifications | 5.91 KB | hamax |
| #1 | support_for_drupal_7-1273132-1.patch | 11.15 KB | hamax |
| zemanta.zip | 12.21 KB | zemanta |
Comments
Comment #1
hamax commentedPatch for Drupal 7 support.
Comment #2
killes@www.drop.org commentedWhat is this about?
Comment #3
killes@www.drop.org commentedguess this belongs over there.
Comment #4
Rok Žlender commentedModule doesn't need to be listed as a file
No spaces between function call -> and names
Also should use node_type_get_names() instead of calling internal _node_types_build
Unstranslated strings. Should be wrapped in t()
Is this line commented out on purpose?
I think here you want to use file_unmanaged_save_data.
You can use $file_destination var from above instead of concatenting directory and basename again.
Watchdog needs to be called with 3rd parameter array of variables http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/watchd...
Comment #5
hamax commentedNew patch with proposed fixes and some minor changes(code review module minor warnings).
Comment #6
Rok Žlender commentedThanks committed to 7 branch.