more cruft to be removed; not being used anymore:

media_url_filter and _media_url_parse_full_links functions.

CommentFileSizeAuthor
#2 remove_unneeded_code-1268268-2.patch2.69 KBidflood

Comments

aaron’s picture

aaron commented

and _media_url_curry as well (all from /includes/media.filter.inc)

idflood’s picture

idflood commented
Status: Active » Needs review
StatusFileSize
new remove_unneeded_code-1268268-2.patch2.69 KB

Here is a simple patch which remove these functions. I've double checked that they weren't used anywhere and verified some more functions.

dddave’s picture

dddave commented

#2: remove_unneeded_code-1268268-2.patch queued for re-testing.

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

I searched through the Media codebase and media_url_filter() is no longer called anywhere. The function also has two helper functions _media_url_parse_full_links() and _media_url_curry().

The patch in #2 still applies cleanly to 7.x-2.x-dev and removes the three functions.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Ok confirmed as well. I removed the code and moved it to a Gist: https://gist.github.com/3020238 so that we still have it somewhere in case we need to bring it back or someone else wants to use it.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #2 to 7.x-2.x. I also marked the 7.x-1.x functions as officially deprecated.

http://drupalcode.org/project/media.git/commit/1d3f52f1 (7.x-2.x)
http://drupalcode.org/project/media.git/commit/93b4d71 (7.x-1.x)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.